Re: reorganize self_alignment_interface (issue 7768043)

2013-03-30 Thread mtsolo
In general, I see a lot of reassigning of parents. What is the goal with this (sorry if you've explained this already)? https://codereview.appspot.com/7768043/diff/38001/lily/fingering-engraver.cc File lily/fingering-engraver.cc (right): https://codereview.appspot.com/7768043/diff/38001/lily/f

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-20 Thread janek . lilypond
Hi all, after some thinking i've come to a conclusion that we should keep this patch as is - just a simple rewrite of self-alignment-interface, without lots of new features and generalizations: they should be done in another patch. Doing so should make git history more logical: there will be a c

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread m...@mikesolomon.org
On 20 mars 2013, at 00:27, Janek Warchoł wrote: > Hi, > > On Tue, Mar 19, 2013 at 11:40 PM, m...@mikesolomon.org > wrote: >> The main reason that I suggest this is that exceptions in the code base lead >> to harder maintenance. >> I am guilty of adding some from time to time (i.e. in stencil

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread Janek Warchoł
Hi, On Tue, Mar 19, 2013 at 11:40 PM, m...@mikesolomon.org wrote: > The main reason that I suggest this is that exceptions in the code base lead > to harder maintenance. > I am guilty of adding some from time to time (i.e. in stencil integral) but I > try to get rid of them as fast as possible.

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread m...@mikesolomon.org
On 19 mars 2013, at 22:04, janek.lilyp...@gmail.com wrote: > Hi Mike & all, > > On 2013/03/19 15:21:37, MikeSol wrote: >> I like where you're going with this. > > cool! :) > >> I would recommend creating a function algined_on_grobs that accepts a > grob, an >> vector of grobs to align to, and a

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread janek . lilypond
Hi Mike & all, On 2013/03/19 15:21:37, MikeSol wrote: I like where you're going with this. cool! :) I would recommend creating a function algined_on_grobs that accepts a grob, an vector of grobs to align to, and an axis. Then algined_on_parent becomes a subset of this where the vector i

Re: reorganize self_alignment_interface (issue 7768043)

2013-03-19 Thread mtsolo
https://codereview.appspot.com/7768043/diff/19001/lily/self-alignment-interface.cc File lily/self-alignment-interface.cc (right): https://codereview.appspot.com/7768043/diff/19001/lily/self-alignment-interface.cc#newcode128 lily/self-alignment-interface.cc:128: /* LilyPond positions every grob r