LGTM
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
all suggestions implemented, thanks all!
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Pál,
LGTM apart from the change in behaviour for dashed barlines: they're
overshooting the outer lines. I couldn't see this from the regtest
comparison for bar-line-dashed.ly, but it's clearly visible on paper.
Cheers,
Neil
http://codereview.appspot.com/4025044/diff/20001/lily/bar-line.cc
On Wed, Jan 26, 2011 at 02:58:44PM +, pkx1...@gmail.com wrote:
> Why is the french version of the chords.itely in this patch and none of
> the other languanges?
If the other languages didn't translate that part of chords.itely,
or if the translations are out of date, then they wouldn't have
"b
Just a nit-pick.
Why is the french version of the chords.itely in this patch and none of
the other languanges?
James
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/l
> Why is the french version of the chords.itely in this patch and none of
> the other languanges?
I grepped for bar-size, was surprised too, but didn't investigate further.
I'll do it again before sending the patches (and if I find anything new,
I'll upload it to Rietveld).
p
___
Looks good to me.
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Looks good to me!
NB: I'm not vouching for the quality of the scheme or C++ code; that's
outside of my expertise. But the .ly files look fine, and the results
(in the form of the regtest comparison) look fine.
http://codereview.appspot.com/4025044/
_
On 2011/01/23 15:00:28, Graham Percival wrote:
Passes regtests, but a few minor nitpicks.
thanks, Graham; all observations implemented.
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.or
Passes regtests, but a few minor nitpicks.
http://codereview.appspot.com/4025044/diff/10001/input/regression/bar-extent.ly
File input/regression/bar-extent.ly (right):
http://codereview.appspot.com/4025044/diff/10001/input/regression/bar-extent.ly#newcode1
input/regression/bar-extent.ly:1: \ver
new patch set up, thanks for reviewing. answers below.
On 2011/01/21 13:50:22, Graham Percival wrote:
The python bits looked fine. I tried a regtest comparison and didn't
see any
change at all other than test-output-distance, so maybe something went
wrong.
Should I see any difference in th
The python bits looked fine. I tried a regtest comparison and didn't
see any change at all other than test-output-distance, so maybe
something went wrong. Should I see any difference in the graphical
output?
I think there's some debugging code in here that needs to be cleaned up.
http://coder
Reviewers: ,
Message:
patchset related to
http://code.google.com/p/lilypond/issues/detail?id=1268
as outlined in
http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00225.html
note that this is the first time I touch Python (for sure) and the
documentation (possibly).
Description:
remov
13 matches
Mail list logo
