2007/4/17, Graham Percival <[EMAIL PROTECTED]>:
> + readFile.close()
>
> superfluous. Happens automatically if it goes out of scope.
I was wondering about this, though: even if they're superfluous, aren't
they good style?
no, IMO not.
--
Han-Wen Nienhuys - [EMAIL PROTECTED] - http://ww
Han-Wen Nienhuys wrote:
some comments
+def copyWithWarning(src, dest):
Thanks, I've made these changes.
+ readFile = open(src, 'r')
'r' : superfluous
+ readFile.close()
superfluous. Happens automatically if it goes out of scope.
I was wondering about this, though: even if th
some comments
+def copyWithWarning(src, dest):
naming: copy_with_warning
+ readFile = open(src, 'r')
'r' : superfluous
+ readFileLines = readFile.readlines()
+ readFile.close()
superfluous. Happens automatically if it goes out of scope.
+ writeFile = open(dest, 'w'
Han-Wen Nienhuys wrote:
There should be a note at the top of every file that mentions this.
Ok, done. I was hoping that the README in that directory would be
enough, but it's easy to add such a warning automatically.
Cheers,
- Graham
___
lilypon
There should be a note at the top of every file that mentions this.
2007/4/11, Werner LEMBERG <[EMAIL PROTECTED]>:
> Thanks for the changes to
> input/lsr/spacing/alignment-vertical-spacing.ly , but remember that
> these files are generated from LSR.
Argh! Thanks for the reminder. I fear it
> Thanks for the changes to
> input/lsr/spacing/alignment-vertical-spacing.ly , but remember that
> these files are generated from LSR.
Argh! Thanks for the reminder. I fear it won't be the last time that
I forget that.
Werner
___
lilypond-dev
Hi Werner,
Thanks for the changes to
input/lsr/spacing/alignment-vertical-spacing.ly , but remember that
these files are generated from LSR. Any changes you make to the git
tree will be overwritten the next time I update the input/lsr/
directory. (which I tend to do about once a week)
I'v
