Re: pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) (issue4398046)

2011-04-16 Thread Carl . D . Sorensen
LGTM Carl http://codereview.appspot.com/4398046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) (issue4398046)

2011-04-16 Thread reinhold . kainhofer
Reviewers: carl.d.sorensen_gmail.com, reinhold_kainhofer.com, Carl, Message: On 2011/04/16 14:43:02, Carl wrote: Bertrand's patch has now been pushed. If you can finish your patch, then we can get it pushed and applied to stable/2.14 Patchset 2 now includes that patch, so now all pdf metada

Re: pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) (issue4398046)

2011-04-16 Thread Carl . D . Sorensen
On 2011/04/14 22:52:04, reinhold_kainhofer.com wrote: Yes, of course! As Graham wants to push Bertrand's patch on Saturday morning, I'll update my patch accordingly. As Bertrand's patch was already out, I didn't even try to include its functionality (but added the TODO comment as a reminder)

Re: pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) (issue4398046)

2011-04-14 Thread Reinhold Kainhofer
On Do., 14. Apr. 2011 23:14:25 CEST, carl.d.soren...@gmail.com wrote: > THe structure of the patch looks good, but I think it conflicts with > Bertrand's patch for 1605.  Perhaps the two could be combined. Yes, of course! As Graham wants to push Bertrand's patch on Saturday morning, I'll update

pdf-metadata: Use UTF-16BE for metadata if required (fix #1502) (issue4398046)

2011-04-14 Thread Carl . D . Sorensen
THe structure of the patch looks good, but I think it conflicts with Bertrand's patch for 1605. Perhaps the two could be combined. Thanks, Carl http://codereview.appspot.com/4398046/diff/1/scm/framework-ps.scm File scm/framework-ps.scm (right): http://codereview.appspot.com/4398046/diff/1/s