Re: patches for LilyPond issues 1503 and 1572

2011-10-31 Thread Carl Sorensen
On 10/31/11 5:58 AM, "Adam Spiers" wrote: >2011/9/10 Janek Warchoł >> Uploaded to Rietveld: http://codereview.appspot.com/4981052/ > >I could be wrong but it looks like Rietveld has all the patches >squashed into a single patch set. Does that mean that when they get >pushed upstream to the of

Re: patches for LilyPond issues 1503 and 1572

2011-10-31 Thread Adam Spiers
2011/9/10 Janek Warchoł > Uploaded to Rietveld: http://codereview.appspot.com/4981052/ I could be wrong but it looks like Rietveld has all the patches squashed into a single patch set. Does that mean that when they get pushed upstream to the official repo, they'll only appear as a single patch?

Re: patches for LilyPond issues 1503 and 1572

2011-10-30 Thread Carl Sorensen
On 10/30/11 6:26 PM, "Adam Spiers" wrote: >2011/10/30 Adam Spiers : >> Hi Janek, >> >> Just a quick note to say that I've started work on this again. >> I'll be in touch again when I've made some progress. > >OK, I've gotten stuck whilst running regression tests against my >feature branch. 'ma

Re: patches for LilyPond issues 1503 and 1572

2011-10-30 Thread Adam Spiers
2011/10/30 Adam Spiers : > Hi Janek, > > Just a quick note to say that I've started work on this again. > I'll be in touch again when I've made some progress. OK, I've gotten stuck whilst running regression tests against my feature branch. 'make test-redo' yields the following error, but I don't

Re: patches for LilyPond issues 1503 and 1572

2011-10-30 Thread Adam Spiers
Hi Janek, Just a quick note to say that I've started work on this again. I'll be in touch again when I've made some progress. 2011/9/10 Janek Warchoł : > Hi Adam, > > 2011/9/10 Adam Spiers : >> Sorry Janek, I did receive the email but I've been away travelling for >> 3 months and only just got ba

Re: patches for LilyPond issues 1503 and 1572

2011-09-10 Thread Janek Warchoł
Hi Adam, 2011/9/10 Adam Spiers : > Sorry Janek, I did receive the email but I've been away travelling for > 3 months and only just got back. No problem! I was afraid that your disappearance meant that you lost interest in these patches. > I would be glad to work with you on > getting these patc

Re: patches for LilyPond issues 1503 and 1572

2011-09-09 Thread Adam Spiers
Sorry Janek, I did receive the email but I've been away travelling for 3 months and only just got back. I would be glad to work with you on getting these patches finalised and submitted, although please bear with me over the next few days as I have some other pressing issues to attend to first. I

patches for LilyPond issues 1503 and 1572

2011-08-22 Thread Janek Warchoł
Hi Adam, apparently you didn't receive my previous e-mail, so i'm writing again. I'd like to help you with your patches about jazz chords display (issue 1503, and also you said that you have some patches for 1572). It looks like they are being overlooked. We should upload them to Rietveld so that