On 1/24/11 3:31 PM, "Benkő Pál" wrote:
>>> please advise me about regression tests: can I modify ligatures within
>>> mensural-ligatures.ly? if not, can I add new ones to the same file?
>>
>> Ancient music has been abandoned by developers for a number of years.
>> IMO, you may do whatever you t
On 2011/01/24 21:27:35, benko.pal wrote:
new patchset up.
please advise me about regression tests: can I modify ligatures within
mensural-ligatures.ly? if not, can I add new ones to the same file?
Ancient music has been abandoned by developers for a number of years.
IMO, you may do whatever
>> please advise me about regression tests: can I modify ligatures within
>> mensural-ligatures.ly? if not, can I add new ones to the same file?
>
> Ancient music has been abandoned by developers for a number of years.
> IMO, you may do whatever you think makes the most sense as you try to
> bring
new patchset up.
please advise me about regression tests: can I modify ligatures within
mensural-ligatures.ly? if not, can I add new ones to the same file?
http://codereview.appspot.com/3797046/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
now I see I forgot to answer a question:
> http://codereview.appspot.com/3797046/diff/1/lily/mensural-ligature-engraver.cc#newcode380
> lily/mensural-ligature-engraver.cc:380: {
> Why put the {} in this case?
because variables defined there should not be seen in the default case.
p
hi Carl, thanks for reviewing!
> Let me start by saying I know *nothing* about mensural notation.
>
> The code looks good to me.
>
> I found only one real issue:
>
> LilyPond coding standards for C++ say that if there is only one
> statement in an if clause, we omit {} around that clause.
that's
Let me start by saying I know *nothing* about mensural notation.
The code looks good to me.
I found only one real issue:
LilyPond coding standards for C++ say that if there is only one
statement in an if clause, we omit {} around that clause.
I also had a question (and it probably doesn't matt
Am 07.01.2011 10:17, schrieb Benkő Pál:
>> Sometimes I have been confused by a punctus divisionis placed in the
>> middle above a ligature, but of course that's something different.
>
> wow, I have never seen such a thing! could you give an example?
The only one I could find quickly is from Apel
> if it helps to confirm that you are right, I might add my own experience
> with mensural sources. Composers/writers seem to literally avoid dotted
> notes in ligatures except (a) at the end of the ligature, or (b) on top
> of the first note of an obliqua, or (c) both. (a) and (b) are frequent,
>
Am 06.01.2011 10:56, schrieb Lukas Pietsch:
> On Thu, 2011-01-06 at 10:49 +0100, Benkő Pál wrote:
>
>>> According to Apel (1962: 99), the general rule would seem to be that the dot
>>> should be on the right if it applies to the final note of the whole
>>> ligature, but on top if it is anywhere el
On Thu, 2011-01-06 at 10:49 +0100, Benkő Pál wrote:
> > According to Apel (1962: 99), the general rule would seem to be that the dot
> > should be on the right if it applies to the final note of the whole
> > ligature, but on top if it is anywhere else (flexa or no flexa). He has one
> > example o
> > One thing I forgot to mention: I've also rewritten dot handling within
> > ligatures. The old code
> > - didn't avoid staff lines
> > - didn't conform actual usage: dotting notes above is not a practice,
> > only if they are first within a flexa, see examples in
> > http://anaigeon.free.fr/mes
On Thu, 2011-01-06 at 08:44 +, benko@gmail.com wrote:
> One thing I forgot to mention: I've also rewritten dot handling within
> ligatures. The old code
> - didn't avoid staff lines
> - didn't conform actual usage: dotting notes above is not a practice,
> only if they are first within a f
One thing I forgot to mention: I've also rewritten dot handling within
ligatures. The old code
- didn't avoid staff lines
- didn't conform actual usage: dotting notes above is not a practice,
only if they are first within a flexa, see examples in
http://anaigeon.free.fr/mes_facs/fsbarb.jpg
http:/
Reviewers: ,
Message:
here is the patch set I hinted at several times:
http://lists.gnu.org/archive/html/lilypond-devel/2010-11/msg00212.html
http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00097.html
some changes are just very slightly related:
mf/parmesan-custodes.mf just makes cus
15 matches
Mail list logo
