Re: markup-command rounded-box is broken

2021-10-10 Thread Thomas Morley
Am So., 10. Okt. 2021 um 11:06 Uhr schrieb Lukas-Fabian Moser : > > > > this would have the advantage to be inline with the doc-string and > > solve the issue at hand. > Should I prepare a MR? Please, do so. Additionally, I'll think a bit deeper about below. Thanks, Harm > > Though, speaking of

Re: markup-command rounded-box is broken

2021-10-10 Thread Lukas-Fabian Moser
this would have the advantage to be inline with the doc-string and solve the issue at hand. Should I prepare a MR? Though, speaking of refactoring rounded-box-stencil. It always bugs me to see some stencil overlaying to get a simple line. Yes, that's an obvious and unpleasant limitation: So

Re: markup-command rounded-box is broken

2021-10-10 Thread Thomas Morley
Am So., 10. Okt. 2021 um 10:21 Uhr schrieb Lukas-Fabian Moser : > > > > So in my impression, rounded-box-stencil might deserve a refactoring > > anyway? > > I would propose: > > lukas@Aquarium:~/git/lilypond/scm(dev/lfm/rounded-box)$ git diff master > diff --git a/scm/define-markup-commands.scm b/s

Re: markup-command rounded-box is broken

2021-10-10 Thread Lukas-Fabian Moser
So in my impression, rounded-box-stencil might deserve a refactoring anyway? I would propose: lukas@Aquarium:~/git/lilypond/scm(dev/lfm/rounded-box)$ git diff master diff --git a/scm/define-markup-commands.scm b/scm/define-markup-commands.scm index cb99a960fe..8b54fd048a 100644 --- a/scm/def

Re: markup-command rounded-box is broken

2021-10-10 Thread James
Hello On 10/10/2021 00:10, Thomas Morley wrote: I noticed a bug with recent master: \markup \rounded-box "foo" prints completely black. First bad commit is: commit 0772e38398972d6c2b4ba9e6f42e7725d973e08b Author: Han-Wen Nienhuys Date: Sun Aug 1 11:15:02 2021 +0200 Stop passing color

Re: markup-command rounded-box is broken

2021-10-10 Thread Lukas-Fabian Moser
Hi Harm, I noticed a bug with recent master: \markup \rounded-box "foo" prints completely black. First bad commit is: commit 0772e38398972d6c2b4ba9e6f42e7725d973e08b Author: Han-Wen Nienhuys Date: Sun Aug 1 11:15:02 2021 +0200 Stop passing color names to output backends Well, compa

markup-command rounded-box is broken

2021-10-09 Thread Thomas Morley
Hi, I noticed a bug with recent master: \markup \rounded-box "foo" prints completely black. First bad commit is: commit 0772e38398972d6c2b4ba9e6f42e7725d973e08b Author: Han-Wen Nienhuys Date: Sun Aug 1 11:15:02 2021 +0200 Stop passing color names to output backends I could fix it with