http://codereview.appspot.com/6211047/diff/20001/lily/bar-line.cc
File lily/bar-line.cc (right):
http://codereview.appspot.com/6211047/diff/20001/lily/bar-line.cc#newcode151
lily/bar-line.cc:151: Real const gap_to_find = (1.0 + 3 * staffline) /
staff_space;
It seems you want
Real const gap_to_fi
hi Keith,
2012/7/10 :
>
> http://codereview.appspot.com/6211047/diff/20001/lily/bar-line.cc
> File lily/bar-line.cc (right):
>
> http://codereview.appspot.com/6211047/diff/20001/lily/bar-line.cc#newcode151
> lily/bar-line.cc:151: Real const gap_to_find = (1.0 + 3 * staffline) /
> staff_space;
> P
http://codereview.appspot.com/6211047/diff/20001/lily/bar-line.cc
File lily/bar-line.cc (right):
http://codereview.appspot.com/6211047/diff/20001/lily/bar-line.cc#newcode151
lily/bar-line.cc:151: Real const gap_to_find = (1.0 + 3 * staffline) /
staff_space;
Pál, see new issue 2648 on the tracker
hi Keith,
thanks for your review.
2012/5/23 :
> Looks good to me.
>
> The regtest changes look like improvements,
> although I wonder if the time-signature and repeat dots should simply
> center around the line closest to zero. If a user sets his
> line-positions entirely below zero, he might /
Looks good to me.
The regtest changes look like improvements,
although I wonder if the time-signature and repeat dots should simply
center around the line closest to zero. If a user sets his
line-positions entirely below zero, he might /want/ the time-signature
above his staff lines. Why else w
Pál, I'm not on a system today that can compile Lilypond so I cannot
look at the points you asked about, at least not today. I hope someone
else can.
http://codereview.appspot.com/6211047/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6211047/diff/1/lily/beam.cc#n
http://codereview.appspot.com/6211047/diff/1/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/6211047/diff/1/lily/beam.cc#newcode1282
lily/beam.cc:1282: staff_span *= 0.5 / staff_space;
division is silly and works only because staff_space is generally 1.
http://codereview.a
LGTM
http://codereview.appspot.com/6211047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: ,
http://codereview.appspot.com/6211047/diff/1/lily/slur-scoring.cc
File lily/slur-scoring.cc (right):
http://codereview.appspot.com/6211047/diff/1/lily/slur-scoring.cc#newcode593
lily/slur-scoring.cc:593: && Staff_symbol_referencer::on_staff_line
(on_staff, (int) rint (pos)))
this c
