Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Graham Percival
On Sun, Jan 02, 2011 at 11:35:33AM +0100, Matthias Kilian wrote: > On Sun, Jan 02, 2011 at 12:55:45AM +, Graham Percival wrote: > > > Bisected to this one (cc'd Neil): > > > > Fantastic! Bisecting is one of the most useful, yet also > > time-consuming, parts of fixing regressions. > > Maybe

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Matthias Kilian
On Sun, Jan 02, 2011 at 04:18:17PM -, Phil Holmes wrote: > "In your original backtrace, is the X_AXIS parent of the Item in frame #2 > 0x0? If so, I'm fine with the patch." > > I've been using this as a learning exercise, and can say that > Item::spanned_rank_interval calls Item::get_column

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Neil Puttock
On 1 January 2011 13:10, Matthias Kilian wrote: > It could be possible to check the result of get_column() in > Item::spanned_rank_interval(), but I'm not sure wether this is the > *proper* bug fix (nor what interval should be returned in this > case). The issue is that the parent shouldn't be a

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Phil Holmes
org ; Neil Puttock Sent: Sunday, January 02, 2011 1:39 AM Subject: Re: issue 1464 (was: a plea to new contributors) On Sun, Jan 2, 2011 at 2:14 AM, Matthias Kilian wrote: On Sat, Jan 01, 2011 at 02:10:04PM +0100, Matthias Kilian wrote: I don't know why gdb doesn't find paper-column

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Matthias Kilian
On Sun, Jan 02, 2011 at 12:35:28PM +0100, Matthias Kilian wrote: > > In your original backtrace, is the X_AXIS parent of the Item in frame #2 > > 0x0? If so, I'm fine with the patch. > > You mean the g in line 197 of axis-group-interface.cc? > > Interval_t rank_span = g->spanned_rank_interv

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Matthias Kilian
On Sun, Jan 02, 2011 at 08:39:03AM +0700, Joe Neeman wrote: > > I tried the diff below, which `fixed' the segfault, but it may be > > completely wrong (I'm currently not familiar with the LilyPond code > > at all). Unfortunately, I don't have a new enough ImageMagick on my > > system, so I can't ru

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Matthias Kilian
On Sun, Jan 02, 2011 at 12:55:45AM +, Graham Percival wrote: > > Bisected to this one (cc'd Neil): > > Fantastic! Bisecting is one of the most useful, yet also > time-consuming, parts of fixing regressions. Maybe time-consuming, but in theory, everyone able to build lilypond from git can wri

Re: issue 1464 (was: a plea to new contributors)

2011-01-01 Thread Joe Neeman
On Sun, Jan 2, 2011 at 2:14 AM, Matthias Kilian wrote: > On Sat, Jan 01, 2011 at 02:10:04PM +0100, Matthias Kilian wrote: > > I don't know why gdb doesn't find paper-column.hh, but anyaway... > > it looks like Item::get_column() returns NULL, because its parent's > > get_column() returns NULL (I c

Re: issue 1464 (was: a plea to new contributors)

2011-01-01 Thread Graham Percival
On Sat, Jan 01, 2011 at 08:14:36PM +0100, Matthias Kilian wrote: > On Sat, Jan 01, 2011 at 02:10:04PM +0100, Matthias Kilian wrote: > > I don't know why gdb doesn't find paper-column.hh, but anyaway... > > it looks like Item::get_column() returns NULL, because its parent's > > get_column() returns

Re: issue 1464 (was: a plea to new contributors)

2011-01-01 Thread Matthias Kilian
On Sat, Jan 01, 2011 at 02:10:04PM +0100, Matthias Kilian wrote: > I don't know why gdb doesn't find paper-column.hh, but anyaway... > it looks like Item::get_column() returns NULL, because its parent's > get_column() returns NULL (I checked that the parent on the X_AXIS > itself is not NULL). Bis

issue 1464 (was: a plea to new contributors)

2011-01-01 Thread Matthias Kilian
On Sat, Jan 01, 2011 at 06:51:49AM +, Graham Percival wrote: > The next step in issue 1464 is just to create a backtrace. See the blurb below this mail (no, I'm not going to sign up at google for adding it there). I don't know why gdb doesn't find paper-column.hh, but anyaway... it looks lik