On Wed, May 9, 2012 at 5:01 PM, Janek Warchoł wrote:
> On Wed, May 9, 2012 at 8:03 AM, wrote:
>>
>> http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
>> File mf/feta-noteheads.mf (right):
>>
>> http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode183
>> mf/fet
On Wed, May 9, 2012 at 8:03 AM, wrote:
>
> http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
> File mf/feta-noteheads.mf (right):
>
> http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode183
> mf/feta-noteheads.mf:183: set_char_box (stemthick# * linecount + gap
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode183
mf/feta-noteheads.mf:183: set_char_box (stemthick# * linecount + gap# *
(linecount - 1),
Jan, the breves seem to be th
Reviewers: janek, Bertrand Bordage, MikeSol, J_lowe, Ian Hulin (gmail),
graham_percival-music.ca,
Message:
On 2011/09/06 16:26:40, Bertrand Bordage wrote:
On 2011/09/06 08:54:40, janek wrote:
> I'm not sure what you mean. Are you saying that i should assign (i
* (gap +
> stemthick), 0) to a
On 2011/09/06 08:54:40, janek wrote:
I'm not sure what you mean. Are you saying that i should assign (i *
(gap +
stemthick), 0) to a variable in the for loop? I.e. sth like
for i := 0 step 1 until linecount - 1:
foobar := (i * (gap + stemthick), 0);
On Tue, Sep 06, 2011 at 08:54:40AM +, janek.lilyp...@gmail.com wrote:
> I have new patch set ready, but i have trouble logging as another user
> in git-cl (this issue was created by my previous e-mail account). Can
> you give me some clue?
Just make a new issue. Follow the instructions in th
Ian,
On 2011/08/30 10:29:42, Ian Hulin (gmail) wrote:
Janek,
Bertrand posted some review comments here.
I think it would be polite in the case of
a newer contributor like Bertrand to
post some responses one way or another
(either "don't worry about it, because. .
." or "nice catch, I'll uploa
Janek,
Bertrand posted some review comments here.
I think it would be polite in the case of a newer contributor like
Bertrand to post some responses one way or another (either "don't worry
about it, because. . ." or "nice catch, I'll upload an updated patch
set".)
Cheers,
Ian
http://codereview.
LGTM
Patch applied and it fixes documents originally showing collisions
between double-lined breves, bar-lines and accidentals.
Cheers,
Ian
http://codereview.appspot.com/4931043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu
passes make and reg tests
http://codereview.appspot.com/4931043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Sorry, I forgot to send the comments.
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf
File mf/feta-noteheads.mf (right):
http://codereview.appspot.com/4931043/diff/1/mf/feta-noteheads.mf#newcode168
mf/feta-noteheads.mf:168: gap# := (0.95 - 0.008 * design_size) *
stemthick#;
Yo
Just a quick review.
Bertrand
http://codereview.appspot.com/4931043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4931043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
13 matches
Mail list logo
