Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-27 Thread Graham Percival
On 2/27/11, Janek Warchoł wrote: > Here you are. This contains all the changes and should apply cleanly > to origin/master. Thanks, pushed. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/l

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-27 Thread Janek Warchoł
2011/2/27 : > On 2011/02/27 07:39:02, wl_gnu.org wrote: >> >> > Well, this nuber is not formed :) It shouldn't depend on >> > staff_radius.  This number determines what the steepness of >> > transition should be (i.e., what the angle of the red line in the >> > attachment will be). This angle shou

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-27 Thread percival . music . ca
On 2011/02/27 07:39:02, wl_gnu.org wrote: > Well, this nuber is not formed :) It shouldn't depend on > staff_radius. This number determines what the steepness of > transition should be (i.e., what the angle of the red line in the > attachment will be). This angle shouldn't depend on Staff_radius

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-26 Thread Werner LEMBERG
>> well, 2*radius+2 then?  Anything that indicates how this number is >> formed is ok. > > Ah, sorry. I missed what you meant. > Well, this nuber is not formed :) It shouldn't depend on > staff_radius. This number determines what the steepness of > transition should be (i.e., what the angle of t

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-26 Thread Janek Warchoł
2011/2/27 Han-Wen Nienhuys > > 2011/2/26 Janek Warchoł : > > http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode360 > >> lily/stem.cc:360: Real shortening_step = min (max (0.25, > >> (shorten_property / 6)), 0.5); > >> shouldnt 6 be 2*staff_radius+1 ? > > > > No, radius of default st

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-26 Thread Han-Wen Nienhuys
2011/2/26 Janek Warchoł : http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode360 >> lily/stem.cc:360: Real shortening_step = min (max (0.25, >> (shorten_property / 6)), 0.5); >> shouldnt 6 be 2*staff_radius+1 ? > > No, radius of default staff is 2, so 2*staff_radius+1 = 5 != 6 well,

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-26 Thread Janek Warchoł
2011/2/25 > LGTM > > just cosmetics. > > > http://codereview.appspot.com/4210051/diff/1/lily/stem.cc > File lily/stem.cc (right): > > http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode336 > lily/stem.cc:336: SCM s = ly_assoc_get (ly_symbol2scm ("lengths"), > details, SCM_EOL); > ca

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-25 Thread hanwenn
LGTM just cosmetics. http://codereview.appspot.com/4210051/diff/1/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/4210051/diff/1/lily/stem.cc#newcode336 lily/stem.cc:336: SCM s = ly_assoc_get (ly_symbol2scm ("lengths"), details, SCM_EOL); can you rename this for easier re

Re: improving the transition between full-length and shortened stems. (issue4210051)

2011-02-24 Thread Graham Percival
On 2/24/11, lemniskata.bernoull...@gmail.com wrote: > This patch handles transition between full length and shortened stems. > It follows Han-Wen suggestions and supports custom stem length and > custom staves. Thanks, this now: http://code.google.com/p/lilypond/issues/detail?id=1538 Cheers, - G

improving the transition between full-length and shortened stems. (issue4210051)

2011-02-24 Thread lemniskata . bernoullego
This patch handles transition between full length and shortened stems. It follows Han-Wen suggestions and supports custom stem length and custom staves. proof-sheets: Lily 2.13.47 output - http://www.sendspace.com/file/7fy9i4 this patch output - http://www.sendspace.com/file/tgmlfc source code: h