2011/6/15 Graham Percival :
> thanks, applied after squashing them into one patch.
issue closed.
> You might want to look into
> git rebase -i origin/master
I know this. This change was originally 4 commits long, i reduced it to 2 :P
Next time i'll reduce more.
> also, your git repo might be u
On Wed, Jun 15, 2011 at 12:33:54PM +0200, Janek Warchoł wrote:
> I should've noticed that also.
>
> Patches attached.
thanks, applied after squashing them into one patch. You might
want to look into
git rebase -i origin/master
also, your git repo might be unhappy the next time you do git
pull
2011/6/15 :
> LGTM, please make one change, then send me the final version for
> pushing.
> http://codereview.appspot.com/4621041/diff/9001/Documentation/contributor/regressions.itexi#newcode215
> Documentation/contributor/regressions.itexi:215: available (relative to
> the current build/ director
LGTM, please make one change, then send me the final version for
pushing.
http://codereview.appspot.com/4621041/diff/9001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/9001/Documentation/contribut
As you wish :)
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201
Documentation/contributor/r
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/5001/Documentation/contributor/regressions.itexi#newcode201
Documentation/contributor/regressions.itexi
@Graham:
perfect! you caught exactly the subtleties which i was worrying that
might be there!
http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/1/Documenta
http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi
File Documentation/contributor/regressions.itexi (right):
http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.itexi#newcode191
Documentation/contributor/regressions.itexi:191:
Reviewers: Graham Percival, james.lowe_datacore.com,
Message:
A small change to the CG to make things more obvious for the beginners.
I hope that what i wrote is true ;)
Rewording suggestions are most welcome.
http://codereview.appspot.com/4621041/diff/1/Documentation/contributor/regressions.i
