> inline constexpr auto VPOS = vsize (-1);
This is now part of
https://gitlab.com/lilypond/lilypond/-/merge_requests/2267
Werner
Forgive me, but I don't see it your way.
Reasoning about the type upon seeing the definition or declaration is the
unlikely case to occur.
The likely case we should be reasoning about is recalling the type upon
seeing a usage.
In that case either you remember what VPOS is, or you open the file wi
>> OK, but don't repeat the type.
>>
>> inline constexpr auto VPOS = vsize (-1);
>>
>
> Well. To that, yes and no. I read it better in the original way,
> [...]
I'm on Dan's side here: Using 'auto' tells me that the right-hand
side's type is exactly the one on the left-hand side, and I can
On Tue, Feb 27, 2024 at 4:55 AM Dan Eble
wrote:
> On 2024-02-27 07:14, Luca Fascione wrote:
> > inline constexpr vsize VPOS (vsize(-1));
>
> OK, but don't repeat the type.
>
> inline constexpr auto VPOS = vsize (-1);
>
Well. To that, yes and no. I read it better in the original way, and
rep
On Tue, Feb 27, 2024 at 4:49 AM Werner LEMBERG wrote:
> According to the MacPorts log file it is the clang compiler that comes
> with XCode 15.0.1 on MaOS 14.2.1. [...] this corresponds to
>
> Apple clang version 15.0.0 (clang-1500.0.40.1)
>
> The used compiler flags are
>
> ```
> CXXFLAGS='-
On 2024-02-27 07:14, Luca Fascione wrote:
inline constexpr vsize VPOS (vsize(-1));
OK, but don't repeat the type.
inline constexpr auto VPOS = vsize (-1);
Personally, I don't like flower's aliases related to vsize,
ssize, and Real -- I'd rather just use standard names --
but I remember t
> However, I can't reproduce it, what compiler flags are you using?
According to the MacPorts log file it is the clang compiler that comes
with XCode 15.0.1 on MaOS 14.2.1. Looking at
https://gist.github.com/yamaya/2924292
this corresponds to
Apple clang version 15.0.0 (clang-1500.0.40.1
I'd just make the cast explicit:
inline constexpr vsize VPOS (vsize(-1));
It's cleaner and requires less updates as the code evolves.
However, I can't reproduce it, what compiler flags are you using?
I'm using -Wall and clang is quiet about this use case
*/tmp %* g++ -Wall -std=c++17 xxx.cc
*/
On 2024-02-27 3:32 am, Werner LEMBERG wrote:
Looking at some MacPorts log files from Mac OS 14.2.1 (which uses the
system's `clang` compiler) I see
```
flower/include/flower-proto.hh:26:30:
warning: implicit conversion changes signedness:
'int' to 'const vsize' (aka 'const unsigned
Looking at some MacPorts log files from Mac OS 14.2.1 (which uses the
system's `clang` compiler) I see
```
flower/include/flower-proto.hh:26:30:
warning: implicit conversion changes signedness:
'int' to 'const vsize' (aka 'const unsigned long')
[-Wsign-conversion]
inline
10 matches
Mail list logo
