Re: checking 2240

2012-01-24 Thread Julien Rioux
On 24/01/2012 6:35 AM, David Kastrup wrote: I think the pairing git apply --index filename.patch git reset --hard has less potential to go wrong if there is a problem at any time. I actually don't really understand why we bother with restoring the tree anyway instead of removing it and doing

Re: checking 2240

2012-01-24 Thread Graham Percival
On Tue, Jan 24, 2012 at 05:33:28PM -0500, Julien Rioux wrote: > On 22/01/2012 2:50 PM, Graham Percival wrote: > > try: > > autoCompile.configure() > > autoCompile.patch(patch_filename) > > autoCompile.build(quick_make=True, > >issue_id=iss

Re: checking 2240

2012-01-24 Thread Julien Rioux
On 22/01/2012 2:50 PM, Graham Percival wrote: On Sun, Jan 22, 2012 at 08:43:26PM +0100, Janek Warchoł wrote: One quick question: Patchy checks patches one at a time, doesn't it? I.e. applies a patch (doesn't commit), tests, unapplies and moves to another patch? ... why are you asking this que

Re: checking 2240

2012-01-24 Thread David Kastrup
David Kastrup writes: > Graham Percival writes: > >> On Tue, Jan 24, 2012 at 12:35:17PM +0100, David Kastrup wrote: >>> has less potential to go wrong if there is a problem at any time. I >>> actually don't really understand why we bother with restoring the tree >>> anyway instead of removing i

Re: checking 2240

2012-01-24 Thread David Kastrup
Graham Percival writes: > On Tue, Jan 24, 2012 at 12:35:17PM +0100, David Kastrup wrote: >> has less potential to go wrong if there is a problem at any time. I >> actually don't really understand why we bother with restoring the tree >> anyway instead of removing it and doing the next test from

Re: checking 2240

2012-01-24 Thread Graham Percival
On Tue, Jan 24, 2012 at 12:35:17PM +0100, David Kastrup wrote: > has less potential to go wrong if there is a problem at any time. I > actually don't really understand why we bother with restoring the tree > anyway instead of removing it and doing the next test from a freshly > created > git clo

Re: checking 2240

2012-01-24 Thread David Kastrup
Janek Warchoł writes: > Hi Julien, > > 2012/1/22 Julien Rioux : >> Hi Janek, >> The autoCompile.patch part is defined here: >> https://github.com/gperciva/lilypond-extra/blob/master/patches/compile_lilypond_test.py#L140 >> >> You'll see that the code uses >> git apply filename.patch >> and >> git

Re: a patch for Patchy (was: Re: checking 2240)

2012-01-22 Thread Janek Warchoł
2012/1/22 Janek Warchoł : > suggested changes for Patchy, which should help dealing with untracked files > like in issue 2240, are here: > https://github.com/janek-warchol/lilypond-extra/commit/301c42579299d62fb24af4fa0ea950b158649da3 This patch fails, Patchy exits with lily@gperciva-desktop:~/s

a patch for Patchy (was: Re: checking 2240)

2012-01-22 Thread Janek Warchoł
Hi, i don't see a way to create a patch file using github, so i've send Graham a pull request and i hope it will be ok. The changes i suggest can be seen here: https://github.com/janek-warchol/lilypond-extra/commit/301c42579299d62fb24af4fa0ea950b158649da3 Graham, if you don't want to bother about

Re: checking 2240

2012-01-22 Thread Janek Warchoł
Hi Julien, 2012/1/22 Julien Rioux : > Hi Janek, > The autoCompile.patch part is defined here: > https://github.com/gperciva/lilypond-extra/blob/master/patches/compile_lilypond_test.py#L140 > > You'll see that the code uses > git apply filename.patch > and > git apply --reverse filename.patch > > I

Re: checking 2240

2012-01-22 Thread Julien Rioux
On 22/01/2012 3:00 PM, Janek Warchoł wrote: 2012/1/22 Graham Percival: why are you asking this question? Is the source code really *that* hard to read? It's 18 lines! Hey, i'm not a pro programmer. There are so many brilliant programmers here that my self-confidence is quite low; this is se

Re: checking 2240

2012-01-22 Thread Janek Warchoł
2012/1/22 Graham Percival : > why are you asking this question?  Is the source code really > *that* hard to read?  It's 18 lines! Hey, i'm not a pro programmer. There are so many brilliant programmers here that my self-confidence is quite low; this is second time i read Python and first time i re

Re: checking 2240

2012-01-22 Thread Graham Percival
On Sun, Jan 22, 2012 at 08:43:26PM +0100, Janek Warchoł wrote: > One quick question: Patchy checks patches one at a time, doesn't it? > I.e. applies a patch (doesn't commit), tests, unapplies and moves to > another patch? ... why are you asking this question? Is the source code really *that* har

Re: checking 2240

2012-01-22 Thread Graham Percival
On Sun, Jan 22, 2012 at 08:16:59PM +0100, Janek Warchoł wrote: > 2012/1/22 Graham Percival : > > Ideally you'd create a github account > > Done: > janek-warchol > > > and then I can let you push directly. > > No review? I hope i won't screw anything up. ok, you have push ability now. You don'

Re: checking 2240

2012-01-22 Thread Janek Warchoł
One quick question: Patchy checks patches one at a time, doesn't it? I.e. applies a patch (doesn't commit), tests, unapplies and moves to another patch? Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/

Re: checking 2240

2012-01-22 Thread Janek Warchoł
2012/1/22 Graham Percival : > On Sun, Jan 22, 2012 at 07:58:09PM +0100, Janek Warchoł wrote: >> i'm preparing a patch addressing David's advice, but i haven't >> found how patches for Patchy are announced, reviewed and pushed.  Do i >> need to create a github account? > > Ideally you'd create a git

Re: checking 2240

2012-01-22 Thread Graham Percival
On Sun, Jan 22, 2012 at 07:58:09PM +0100, Janek Warchoł wrote: > In an old e-mail i've found a link to what looks like Patchy source code > https://github.com/gperciva/lilypond-extra/blob/master/patches/compile_lilypond_test.py Correct. > and i'm preparing a patch addressing David's advice, but i

Re: checking 2240

2012-01-22 Thread Janek Warchoł
Hi, 2012/1/22 David Kastrup : > Graham Percival writes: >> With respect to this patch, you have 4 options: >> - modify Patchy to do the appropriate build stuff. >> - recruit somebody else to modify Patchy for you. >> [...] > > [Patchy's automated testing got confused by stale files in its work

Re: checking 2240

2012-01-22 Thread David Kastrup
Graham Percival writes: > On Sun, Jan 22, 2012 at 11:35:55AM +0100, David Kastrup wrote: >> >> So please accept my apologies that I can't defend this patch further >> today. It does not mean that I am not serious about it, and I >> definitely believe that if Graham double-checks the comments on

Re: checking 2240 (was: 2.16 release candidate 3 imminent)

2012-01-22 Thread m...@apollinemike.com
On Jan 22, 2012, at 12:44 PM, Graham Percival wrote: > > (I don't want to put Mike on the spot, but a week ago I sent > him this same email and he fixed the relevant problem in Patchy, > so he might be willing to modify Patchy for this) See spot run! Run spot run! I have compositions coming

checking 2240 (was: 2.16 release candidate 3 imminent)

2012-01-22 Thread Graham Percival
On Sun, Jan 22, 2012 at 11:35:55AM +0100, David Kastrup wrote: > > So please accept my apologies that I can't defend this patch further > today. It does not mean that I am not serious about it, and I > definitely believe that if Graham double-checks the comments on this > patch, he'll find the re