Re: changing shape of the G clef (issue4664070)

2011-07-27 Thread lemniskata . bernoullego
Going back to replacing the clef only. Old glyph is no longer in the patch, we may discuss it separately. http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: changing shape of the G clef (issue4664070)

2011-07-23 Thread lemniskata . bernoullego
I guess this fixes the problem with "old" style for non-G clefs. http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc File lily/clef.cc (right): http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51 lily/clef.cc:51: str = str + "_" + clef_style; On 2011/07/17 21:09:45,

Re: changing shape of the G clef (issue4664070)

2011-07-17 Thread Han-Wen Nienhuys
2011/7/16 Janek Warchoł : >> This is exactly the thin edge of the \override glyph >> wedge I was worried about earlier :(  We already have >> too many overrides. > > I think we shouldn't delete it immediately.  We sometimes leave old > syntax for some time; let's keep old clef glyph until 2.18.  T

Re: changing shape of the G clef (issue4664070)

2011-07-17 Thread n . puttock
http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc File lily/clef.cc (right): http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51 lily/clef.cc:51: str = str + "_" + clef_style; you can't add clef_style unless you know glyph == "clefs.G" http://codereview.appspot.com

Re: changing shape of the G clef (issue4664070)

2011-07-16 Thread Janek Warchoł
2011/7/16 Trevor Daniels : > >> \override Staff.Clef #'style = #'old  tells Lily to use previous clef >> glyph instead of my new clef. >> (dedicated to James) > > This is exactly the thin edge of the \override glyph > wedge I was worried about earlier :(  We already have > too many overrides. I th

Re: changing shape of the G clef (issue4664070)

2011-07-16 Thread Trevor Daniels
\override Staff.Clef #'style = #'old tells Lily to use previous clef glyph instead of my new clef. (dedicated to James) This is exactly the thin edge of the \override glyph wedge I was worried about earlier :( We already have too many overrides. If the majority want to change the clef let'

Re: changing shape of the G clef (issue4664070)

2011-07-16 Thread lemniskata . bernoullego
New patch set uploaded. \override Staff.Clef #'style = #'old tells Lily to use previous clef glyph instead of my new clef. (dedicated to James) http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://list

Re: changing shape of the G clef (issue4664070)

2011-07-11 Thread lemniskata . bernoullego
New patch set uploaded - the suggested clef is a bit higher now. Images can be found in tracker issue: http://code.google.com/p/lilypond/issues/detail?id=1752 http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.or

Re: changing shape of the G clef (issue4664070)

2011-07-08 Thread Janek Warchoł
2011/7/9 : > Please add an issue to the tracker, with images of both clefs, so we can > see the comparison side by side.  There should be pdf versions of both > clefs, or high-resolution images (1200 dpi or so). http://code.google.com/p/lilypond/issues/detail?id=1752 i'll add some pdfs tomorrow,

Re: changing shape of the G clef (issue4664070)

2011-07-08 Thread Carl . D . Sorensen
Please add an issue to the tracker, with images of both clefs, so we can see the comparison side by side. There should be pdf versions of both clefs, or high-resolution images (1200 dpi or so). Thanks, Carl http://codereview.appspot.com/4664070/ __

changing shape of the G clef (issue4664070)

2011-07-08 Thread lemniskata . bernoullego
Reviewers: Reinhold, james.lowe_datacore.com, x.scheuer_gmail.com, Message: A tip to speed up work if you try to modify clef shape: use this script to generate a dvi preview of glyphs (no need to run make, and it also shows metafont control points): #!/bin/bash mf '\mode:=proof; input feta20' gf