Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-17 Thread janek . lilypond
pushed as a2d8779a847dab1b6622da59be3a0e9247ff2ab2 thanks, Janek http://codereview.appspot.com/4962072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-14 Thread pkx166h
passes make and reg tests - there are three reg tests that show up but nothing significant. See http://code.google.com/p/lilypond/issues/detail?id=1883#c1 http://codereview.appspot.com/4962072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org ht

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-13 Thread ianhulin44
LGTM Ian http://codereview.appspot.com/4962072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-13 Thread janek . lilypond
New patch set uploaded. http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#newcode120 mf/feta-noteheads.mf:120: On 2011/09/13 08:58:57, Ian Hulin (gmail) wrote: foobar = quanted_

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-13 Thread bordage . bertrand
LGTM, with the same comment. http://codereview.appspot.com/4962072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-13 Thread ianhulin44
Mostly LGTM, apart from one calculation you do four times. Do it once once and save as a variable and use that. Cheers, Ian http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf File mf/feta-noteheads.mf (right): http://codereview.appspot.com/4962072/diff/1/mf/feta-noteheads.mf#ne

change longas similarly to how breves were changed (issue 4962072)

2011-09-12 Thread janek . lilypond
Reviewers: Bertrand Bordage, Message: http://code.google.com/p/lilypond/issues/detail?id=1883 Description: change longas similarly to how breves were changed Put vertical lines farther apart, make them longer to increase readability and include them in X-extent. Please review this at http://co