Re: book parts

2008-11-16 Thread Nicolas Sceaux
Le 15 nov. 08 à 11:51, Nicolas Sceaux a écrit : Le 15 nov. 08 à 01:00, Graham Percival a écrit : I hate to nag, but what's the status of the book parts? Do you think it might be ready for 2.11.64 ? Cheers, - Graham I have made the corrections suggested by Joe, plus the fix for an

Re: Nested book parts

2008-11-16 Thread nicolas . sceaux
http://codereview.appspot.com/4848/diff/806/615 File lily/page-breaking.cc (right): http://codereview.appspot.com/4848/diff/806/615#newcode227 Line 227: ly_symbol2scm ("is-part-last"), scm_from_bool (last), On 2008/11/03 00:27:51, joeneeman wrote: A really minor naming nitpick, but you have is-

Re: book parts

2008-11-15 Thread Nicolas Sceaux
Le 15 nov. 08 à 01:00, Graham Percival a écrit : I hate to nag, but what's the status of the book parts? Do you think it might be ready for 2.11.64 ? Cheers, - Graham I have made the corrections suggested by Joe, plus the fix for another problem that I met when using book parts in real

book parts

2008-11-14 Thread Graham Percival
I hate to nag, but what's the status of the book parts? Do you think it might be ready for 2.11.64 ? Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Nested book parts

2008-11-02 Thread joeneeman
Look good, just one nitpick. http://codereview.appspot.com/4848/diff/806/615 File lily/page-breaking.cc (right): http://codereview.appspot.com/4848/diff/806/615#newcode227 Line 227: ly_symbol2scm ("is-part-last"), scm_from_bool (last), A really minor naming nitpick, but you have is-last and is-

Re: Nested book parts

2008-10-28 Thread Nicolas Sceaux
Hi, I've uploaded a 3rd patch. Compared with the 2nd (which addresses the issues raised by Joe), it implements two things: - it is possible, in header and footer markups, to know whether a page is the first or last page of book or of a part, using the predicates first-page last-page

Re: Nested book parts

2008-10-18 Thread Graham Percival
spacing with ragged-last-bottom. > `last_from_book' is used to know where to put the tagline. We do not > want a tagline at every last page of book parts. ... > `is_first' is useless indeed (remainer of previous implementation) > but `is_last' is useful, not to put tagline

Re: Nested book parts

2008-10-18 Thread nicolas . sceaux
part-first-page-number"), 1); On 2008/10/15 01:06:06, joeneeman wrote: Do we really need new variables for properties in book parts (as opposed to using some cascading to allow bookparts to override properties in the parent)? I could see this leading to an explosion of properties. indeed

Re: Nested book parts

2008-10-14 Thread hanwenn
http://codereview.appspot.com/4848/diff/1/5 File lily/include/book.hh (right): http://codereview.appspot.com/4848/diff/1/5#newcode35 Line 35: void add_bookpart (); On 2008/10/15 01:06:06, joeneeman wrote: Can this be private? Yeah, I know everything else here is public, but that's no reason t

Nested book parts

2008-10-14 Thread joeneeman
vsize first_page_num = robust_scm2int (book_->paper_->c_variable ("part-first-page-number"), 1); Do we really need new variables for properties in book parts (as opposed to using some cascading to allow bookparts to override properties in the parent)? I could see this leading

Re: RFC: book parts

2008-08-23 Thread Nicolas Sceaux
Le 18 août 08 à 08:08, Joe Neeman a écrit : On Sun, 2008-08-17 at 00:25 +0200, Nicolas Sceaux wrote: Hi, I have taken advantage of this rainy week-end to work on an implementation of book parts. I'd like to know whether this draft patch qualifies as relatively simple, before goi

Re: RFC: book parts

2008-08-21 Thread Nicolas Sceaux
Le 18 août 08 à 08:08, Joe Neeman a écrit : On Sun, 2008-08-17 at 00:25 +0200, Nicolas Sceaux wrote: Hi, I have taken advantage of this rainy week-end to work on an implementation of book parts. I'd like to know whether this draft patch qualifies as relatively simple, before goi

Re: RFC: book parts

2008-08-18 Thread Joe Neeman
On Sun, 2008-08-17 at 00:25 +0200, Nicolas Sceaux wrote: > Hi, > > I have taken advantage of this rainy week-end to work on an > implementation of book parts. I'd like to know whether this draft > patch qualifies as relatively simple, before going on polishing it. >

Re: RFC: book parts

2008-06-26 Thread Nicolas Sceaux
Le 24 juin 08 à 17:26, Joe Neeman a écrit : I remember this has been previously discussed on the mailing list, but I can´t find it; can you remind me why the default breaker doesn ´t work with text? The default page breaker does not completely fill a page with text, but somewhat "averages" s

Re: RFC: book parts

2008-06-24 Thread Joe Neeman
On Sun, Jun 22, 2008 at 12:38 PM, Nicolas Sceaux <[EMAIL PROTECTED]> wrote: > Hi, > > When typesetting a book with many scores and with possibly some text > sections, page breaking may become an inextricable issue: > > 1) the default, "optimal", page breaker, which gives the best result > wrt lin

RFC: book parts

2008-06-22 Thread Nicolas Sceaux
Hi, When typesetting a book with many scores and with possibly some text sections, page breaking may become an inextricable issue: 1) the default, "optimal", page breaker, which gives the best result wrt line and page breaking when there is no or little text, cannot be used when the book is ve