Re: an example of minimal example (issue4636082)

2011-07-14 Thread Graham Percival
On Thu, Jul 14, 2011 at 09:59:44PM +0200, Janek Warchoł wrote: > I attach the patch, feel free to push it (i cannot). Thanks, pushed. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypon

Re: an example of minimal example (issue4636082)

2011-07-14 Thread Janek Warchoł
2011/7/14 : > This has had its countdown; please push and close. I attach the patch, feel free to push it (i cannot). cheers, Janek From 55ac6f7e56bcd42a6464a35378f02046aee4d2f7 Mon Sep 17 00:00:00 2001 From: Janek Warchol Date: Mon, 4 Jul 2011 21:39:28 +0200 Subject: [PATCH] an example of mini

Re: an example of minimal example (issue4636082)

2011-07-13 Thread ColinPKCampbell
This has had its countdown; please push and close. http://codereview.appspot.com/4636082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

2011-07-11 Thread percival . music . ca
LGTM http://codereview.appspot.com/4636082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

2011-07-10 Thread lemniskata . bernoullego
New patch set uploaded. I think that everything works now. cheers, Janek http://codereview.appspot.com/4636082/diff/10003/Documentation/css/lilypond-website.css File Documentation/css/lilypond-website.css (right): http://codereview.appspot.com/4636082/diff/10003/Documentation/css/lilypond-webs

Re: an example of minimal example (issue4636082)

2011-07-09 Thread Graham Percival
On Sat, Jul 09, 2011 at 12:33:04PM +0200, David Kastrup wrote: > Graham Percival writes: > > > Graphical samples are a royal people for people like me to create. ^ pain. > Oh. I would have thought you a commoner. No, actually -- I was born on January 6, as the third of 3 boys born in that hos

Re: an example of minimal example (issue4636082)

2011-07-09 Thread David Kastrup
Graham Percival writes: > On Sat, Jul 09, 2011 at 07:58:52AM +, > lemniskata.bernoull...@gmail.com wrote: >> >Optionally, attach an image showing the desired graphical output. >> >> "desired graphical output" is very nice and elegant, but i wouldn't >> change "if possible" to "optionally".

Re: an example of minimal example (issue4636082)

2011-07-09 Thread Graham Percival
On Sat, Jul 09, 2011 at 07:58:52AM +, lemniskata.bernoull...@gmail.com wrote: > >Optionally, attach an image showing the desired graphical output. > > "desired graphical output" is very nice and elegant, but i wouldn't > change "if possible" to "optionally". IMO graphical samples are *very*

Re: an example of minimal example (issue4636082)

2011-07-09 Thread lemniskata . bernoullego
New patch set uploaded. http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi#newcode320 Documentation/web/community.itexi:320: or @cod

Re: an example of minimal example (issue4636082)

2011-07-09 Thread percival . music . ca
http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi#newcode320 Documentation/web/community.itexi:320: or @code{%@{ @dots{} %@}})} sect

Re: an example of minimal example (issue4636082)

2011-07-08 Thread lemniskata . bernoullego
Reverted sentence about \version. Ready to go? http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/commun

Re: an example of minimal example (issue4636082)

2011-07-07 Thread percival . music . ca
http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/community.itexi:311: Specify which release of LilyPond

Re: an example of minimal example (issue4636082)

2011-07-06 Thread lemniskata . bernoullego
http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/community.itexi:311: Specify which release of LilyPond

Re: an example of minimal example (issue4636082)

2011-07-06 Thread percival . music . ca
I'm in a boring presentation. http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/community.itexi:311: Spe

Re: an example of minimal example (issue4636082)

2011-07-05 Thread lemniskata . bernoullego
New patch set uploaded. I have a problem with the box at the bottom: code examples are center-aligned, not left-aligned. I didn't found any example of how it's done in our manuals; i searched texinfo documentation and found @flushleft, but it didn't work... How should i do this? http://coderev

Re: an example of minimal example (issue4636082)

2011-07-05 Thread Janek Warchoł
2011/7/5 Graham Percival > > On Mon, Jul 04, 2011 at 11:46:30PM +0200, Janek Warchoł wrote: > > 2011/7/4  : > > > On 2011/07/04 21:01:44, Janek Warchol wrote: > > >> Umm.. is it right now? > > > > > > why the mao are you asking me?  Cut&paste this and tell me yourself: > > >  cd build/ > > >  make

Re: an example of minimal example (issue4636082)

2011-07-05 Thread Phil Holmes
- Original Message - From: "Janek Warchoł" To: ; ; ; ; ; Sent: Monday, July 04, 2011 10:46 PM Subject: Re: an example of minimal example (issue4636082) 2011/7/4 : On 2011/07/04 21:01:44, Janek Warchol wrote: Umm.. is it right now? why the mao are you asking me? Cut&

Re: an example of minimal example (issue4636082)

2011-07-04 Thread pkx166h
Hello, my comments inline. James http://codereview.appspot.com/4636082/diff/10001/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/10001/Documentation/web/community.itexi#newcode283 Documentation/web/community.itexi:28

Re: an example of minimal example (issue4636082)

2011-07-04 Thread Graham Percival
On Mon, Jul 04, 2011 at 11:46:30PM +0200, Janek Warchoł wrote: > 2011/7/4 : > > On 2011/07/04 21:01:44, Janek Warchol wrote: > >> Umm.. is it right now? > > > > why the mao are you asking me?  Cut&paste this and tell me yourself: > >  cd build/ > >  make website > > > > It either compiles, or it d

Re: an example of minimal example (issue4636082)

2011-07-04 Thread Janek Warchoł
2011/7/4 : > On 2011/07/04 21:01:44, Janek Warchol wrote: >> Umm.. is it right now? > > why the mao are you asking me?  Cut&paste this and tell me yourself: >  cd build/ >  make website > > It either compiles, or it doesn't. Ooops, sorry... I didn't know that it's possible to compile website sepa

Re: an example of minimal example (issue4636082)

2011-07-04 Thread percival . music . ca
On 2011/07/04 21:01:44, Janek Warchol wrote: 2011/7/4 : > this won't compile; it would have to be @example instead, and that will require > @{ @} escapes. Umm.. is it right now? why the mao are you asking me? Cut&paste this and tell me yourself: cd build/ make website It either comp

Re: an example of minimal example (issue4636082)

2011-07-04 Thread lemniskata . bernoullego
New patch set uploaded. 2011/7/4 : I'm glad that you're working on it!  I'm just warning you that there will be many nitpicks. No problem. If they aren't about code style, i can handle them :) http://codereview.appspot.com/4636082/diff/3/Documentation/web/community.itexi File Documentation

Re: an example of minimal example (issue4636082)

2011-07-04 Thread lemniskata . bernoullego
On 2011/07/04 20:02:59, Carl wrote: I like this, but I think it should have a little bit more information. I don't think that the changes in the comments affect whether it is minimal or not -- perhaps the comments should be the same in both cases. Imo it's more readable when the comment is

Re: an example of minimal example (issue4636082)

2011-07-04 Thread percival . music . ca
We need to be careful about adding stuff to the webpage; perfection is when there's nothing left to remove, not when there's nothing left to add. I'm glad that you're working on it! I'm just warning you that there will be many nitpicks. http://codereview.appspot.com/4636082/diff/3/Documentatio

Re: an example of minimal example (issue4636082)

2011-07-04 Thread Carl . D . Sorensen
I like this, but I think it should have a little bit more information. I don't think that the changes in the comments affect whether it is minimal or not -- perhaps the comments should be the same in both cases. What we wanted to get rid of is any unnecessary LilyPond input. In this case that

an example of minimal example (issue4636082)

2011-07-04 Thread lemniskata . bernoullego
Reviewers: Graham Percival, james.lowe_datacore.com, Message: In response to http://lists.gnu.org/archive/html/lilypond-user/2011-07/msg00060.html Description: an example of minimal example for some people it's not clear enough how tiny a tiny example should be. So i used a recently discussed e