Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-28 Thread janek . lilypond
LGTM http://codereview.appspot.com/6742061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread marc
On 2012/10/23 23:22:03, J_lowe wrote: One typo so, as we need to fix this, I also included a minor grammar change. Otherwise LGTM. https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread pkx166h
One typo so, as we need to fix this, I also included a minor grammar change. Otherwise LGTM. https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/6742061/diff/10001/Documentati

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread marc
On 2012/10/23 09:03:32, J_lowe wrote: Mark, Nearly there. Hey, sounds prominsing ;-) Some more general comments - some are Doc Policy, some are my own views on how to organize this section, also can you make sure you use two spaces after a full point (full stop) as this is also the CG

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-23 Thread pkx166h
Mark, Nearly there. Some more general comments - some are Doc Policy, some are my own views on how to organize this section, also can you make sure you use two spaces after a full point (full stop) as this is also the CG policy (even if it does go against every grain in my typographically-based

Re: adds documentation for the new bar line interface (issue 6742061)

2012-10-22 Thread marc
Reviewers: J_lowe, Message: James, thanks for your remarks and corrections! Some answers (partly preliminal) are listed below. https://codereview.appspot.com/6742061/diff/2001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.c

adds documentation for the new bar line interface (issue 6742061)

2012-10-22 Thread pkx166h
Thanks for doing this. Some comments (it's the one thing I feel competent enough to join in and make suggestions on). James https://codereview.appspot.com/6742061/diff/2001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/6