Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-22 Thread Keith OHara
On Fri, 22 Jun 2012 08:21:02 -0700, Janek Warchoł wrote: The new property X-alignment will be awkward to use, because it is a complex structure of unnamed conceptually-distinct objects. Unnamed? What do you mean? If you change things as you have the patch now, when someone asks, over the

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-22 Thread Keith OHara
On Fri, 22 Jun 2012 08:21:02 -0700, Janek Warchoł wrote: On Fri, Jun 22, 2012 at 7:41 AM, wrote: This fails an assertion in scm_or_str2symbol, so I had to recompile with NDEBUG I'm sorry, but i don't recognize what failing an assertion in scm_or_str2symbol could mean here. Neither did I

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-22 Thread Janek Warchoł
On Fri, Jun 22, 2012 at 7:41 AM, wrote: > This fails an assertion in scm_or_str2symbol, so I had to recompile with > NDEBUG I'm sorry, but i don't recognize what failing an assertion in scm_or_str2symbol could mean here. Was this related to bad docstrings? (they are fixed now) >> Nevertheless

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-21 Thread k-ohara5a5a
This fails an assertion in scm_or_str2symbol, so I had to recompile with NDEBUG On 2012/06/21 07:36:31, janek wrote: Nevertheless, it's possible to override X-offset property on the ly code to use this: \override LyricText #'X-offset = #(ly:make-simple-closure (ly:make-simple-closure (l

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-21 Thread dak
http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm#newcode969 scm/define-grob-properties.scm:969: be used (for example X@tie{}extent) and the

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-21 Thread k-ohara5a5a
Looks good; I hope to try it using your example-input on the bug-tracker issue 2613 within a day or so. http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-p

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-21 Thread janek . lilypond
http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm#newcode984 scm/define-grob-properties.scm:984: (Y-alignment ,list? "3-element list specifyi

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-21 Thread mtsolo
http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): http://codereview.appspot.com/6308093/diff/10001/scm/define-grob-properties.scm#newcode984 scm/define-grob-properties.scm:984: (Y-alignment ,list? "3-element list specifyi

Re: add general_alignment (issue 2613) (issue 6308093)

2012-06-21 Thread janek . lilypond
Hi all, i've found why it was breaking make - an interface for properties was missing. It is added now. I've decided not to change any grob properties with this patch (i.e. only add new method, not use it yet). Thus, there should be no regressions at all. Nevertheless, it's possible to overrid