Thank you Patrick!
All of your comments have been incorporated into a new patch, which draws
the svgs a-ok (see attached).
~Mike
On 6/19/10 12:42 AM, "pnor...@gmail.com" wrote:
> Hi Mike,
>
> This is very impressive. Thanks for your work on this. I just have a
> few comments for you about t
Hi Mike,
This is very impressive. Thanks for your work on this. I just have a
few comments for you about the SVG-related code.
Thanks,
Patrick
http://codereview.appspot.com/1425041/diff/12001/13007
File scm/lily-library.scm (right):
http://codereview.appspot.com/1425041/diff/12001/13007#new
Mike,
I'm sorry, but I had some comments earlier that I somehow erased with
inadvertent keystrokes, so I added them back in.
Thanks,
Carl
http://codereview.appspot.com/1425041/diff/1/8
File scm/lily-library.scm (right):
http://codereview.appspot.com/1425041/diff/1/8#newcode522
scm/lily-libr
Reviewers: carl.d.sorensen_gmail.com, MikeSol,
Message:
Hi Mike,
This is super work, you're obviously a schemer extraordinaire. ;)
I've copied my comments from the original set, and added a few more
(you'll see some reiterate Carl's points).
I think woodwind-diagrams.scm is a bit unwieldy in i
The new patch worked.
I've put some comments in line.
Great job, Mike!
http://codereview.appspot.com/1425041/diff/1/8
File scm/lily-library.scm (right):
http://codereview.appspot.com/1425041/diff/1/8#newcode492
scm/lily-library.scm:492: (cons
In general, I prefer to have the first argument on
