Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-16 Thread percival . music . ca
countdown over, please push whenever it's convenient, Keith. http://codereview.appspot.com/4517136/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-09 Thread joeneeman
ok, lgtm http://codereview.appspot.com/4517136/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread k-ohara5a5a
On 2011/06/04 17:32:15, joeneeman wrote: > When compressing, unstretchable springs never get put on the > active list, since their blocking_force is 0. It seems, though, that unstretchable but compressible springs should be on the active list when compressing. They are. They have blocking

Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread joeneeman
http://codereview.appspot.com/4517136/diff/1001/lily/simple-spacer.cc File lily/simple-spacer.cc (right): http://codereview.appspot.com/4517136/diff/1001/lily/simple-spacer.cc#newcode230 lily/simple-spacer.cc:230: for (++i; i < sorted_springs.size (); i++) On 2011/06/04 10:48:09, Keith wrote: O

Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread k-ohara5a5a
Reviewers: joeneeman, http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc File lily/align-interface.cc (left): http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc#oldcode230 lily/align-interface.cc:230: dy = max (dy, Page_layout_problem::get_fixed_spacing

Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread joeneeman
http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc File lily/align-interface.cc (left): http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc#oldcode230 lily/align-interface.cc:230: dy = max (dy, Page_layout_problem::get_fixed_spacing (elems[j-1], elems[j],