I agree with joe that there is a lot of duplicate here; it must be
possible to rewrite this more tightly.
That said, the fret-diagram code is completely your domain, so it's your
call.
http://codereview.appspot.com/11857/diff/1/4
File scm/fret-diagrams.scm (right):
http://codereview.appspot.co
On 1/2/09 9:16 PM, "Joe Neeman" wrote:
> On Saturday 03 January 2009 02:30:36 pm Carl D. Sorensen wrote:
>> Thanks for the review, Joe.
>>
>> On 1/2/09 4:17 PM, "joenee...@gmail.com" wrote:
>>> Reviewers: Carl.D.Sorensen,
>>>
>>>
>>> http://codereview.appspot.com/11857/diff/1/2
>>> File inpu
On Saturday 03 January 2009 02:30:36 pm Carl D. Sorensen wrote:
> Thanks for the review, Joe.
>
> On 1/2/09 4:17 PM, "joenee...@gmail.com" wrote:
> > Reviewers: Carl.D.Sorensen,
> >
> >
> > http://codereview.appspot.com/11857/diff/1/2
> > File input/regression/fret-diagrams.ly (right):
> >
> > htt
Thanks for the review, Joe.
On 1/2/09 4:17 PM, "joenee...@gmail.com" wrote:
> Reviewers: Carl.D.Sorensen,
>
>
> http://codereview.appspot.com/11857/diff/1/2
> File input/regression/fret-diagrams.ly (right):
>
> http://codereview.appspot.com/11857/diff/1/2#newcode1
> Line 1: \version "2.12.0"
aw-strings (- string-count 1) fret-range th size orientation)
gap))
Description:
Updates to fret-diagrams
Add new orientation opposing-landscape as requested by user
Revise orientation code so 'normal is always a default (in
the else clause of a cond)
Adjust the origin of the fret diag
