Re: Tremolo positioning

2006-03-30 Thread Joe Neeman
On Thu, 30 Mar 2006 20:58, Han-Wen Nienhuys wrote: > Joe Neeman wrote: > > 2006-03-30 Joe Neeman <[EMAIL PROTECTED]> > > * lily/chord-tremolo-engraver.cc (acknowledge_stem): set the > > stem-tremolo object in the stem (or else the stem might not be > > long enough). > > just a minor n

Re: Tremolo positioning

2006-03-30 Thread Han-Wen Nienhuys
Joe Neeman wrote: 2006-03-30 Joe Neeman <[EMAIL PROTECTED]> * lily/chord-tremolo-engraver.cc (acknowledge_stem): set the stem-tremolo object in the stem (or else the stem might not be long enough). just a minor nit, but can you follow the ChangeLog style exactly? ie. tab for ind

Re: Tremolo positioning

2006-03-30 Thread Joe Neeman
On Thu, 30 Mar 2006 19:59, Werner LEMBERG wrote: > > > I've just realised that I caused a regression for tremolos > > > > > > > on whole notes. I'll fix that today. > > And here a problem with \stemUp, using the CVS from today, 7:23 CEST. Nothing to do with \stemUp, it's because you used \repeat "t

Re: Tremolo positioning

2006-03-30 Thread Werner LEMBERG
> > I've just realised that I caused a regression for tremolos > > > on whole notes. I'll fix that today. And here a problem with \stemUp, using the CVS from today, 7:23 CEST. Werner == \relative c'' { \stemUp \repeat

Re: Tremolo positioning

2006-03-29 Thread Joe Neeman
On Thu, 30 Mar 2006 10:55, Han-Wen Nienhuys wrote: > Joe Neeman wrote: > I've just realised that I caused a regression for tremolos > > on whole notes. I'll fix that today. > > Please do. Here we are: 2006-03-30 Joe Neeman <[EMAIL PROTECTED]> * lily/stem-tremolo.cc (print): for whole notes

Re: Tremolo positioning

2006-03-29 Thread Han-Wen Nienhuys
Joe Neeman wrote: On Thu, 30 Mar 2006 01:46, Han-Wen Nienhuys wrote: thanks. I've added your changes to 2.9 ; I'll probably backport the diff of 2.9.0 to 2.8.1 as a whole. Before you do, I've just realised that I caused a regression for tremolos on whole notes. I'll fix that today. Please d

Re: Tremolo positioning

2006-03-29 Thread Joe Neeman
On Thu, 30 Mar 2006 01:46, Han-Wen Nienhuys wrote: > thanks. I've added your changes to 2.9 ; I'll probably backport the diff > of 2.9.0 to 2.8.1 as a whole. Before you do, I've just realised that I caused a regression for tremolos on whole notes. I'll fix that today. > Can you look at the regtes

Re: Tremolo positioning

2006-03-29 Thread Juergen Reuter
Please note that the property name "style" currently (hopefully) consistently denotes _font_ style. It is defined with this meaning for noteheads, rests, accidentals, time signatures, flags, and custos. Nowadays, that Lily supports subproperties (cp. manual Sect. 9.1.4 or 9.2.1), maybe, on

Re: Tremolo positioning

2006-03-29 Thread Han-Wen Nienhuys
Joe Neeman wrote: On Tue, 28 Mar 2006 20:20, Han-Wen Nienhuys wrote: Han-Wen Nienhuys wrote: Can you resend the patch using more idiomatic code? Thanks! Also, can you include a small regression test sample, so it's obvious when we break something? I'm not quite sure if we reached a conclusio

Re: Tremolo positioning

2006-03-29 Thread Joe Neeman
minlen -= 1.0; - } +{ + Real beam_trans = Stem_tremolo::get_beam_translation (t_flag); + /* the obvious choice is (durlog - 2) here, but we need a bit more space. */ + minlen += 2 * (durlog - 1.5) * beam_trans; + + /* up-stems need even a little mo

Re: Tremolo positioning

2006-03-28 Thread Joshua Parmenter
This is great to know. While I am still learning syntax, etc. of lilypond, perhaps the first thing I can volunteer to do in the near future is program some of the more common (or attainable) house style sheets. Like I said, I believe I have the Durand sheet somewhere. If anyone else out the

Re: Tremolo positioning

2006-03-28 Thread Graham Percival
On 28-Mar-06, at 3:56 PM, Joshua Parmenter wrote: If you're new here, you may not realise that almost everything in lilypond is configurable. As things stand, you can do Of course... I have only started working through the tutorial... so perhaps I should just keep a little quiet until I kno

Re: Tremolo positioning

2006-03-28 Thread Joshua Parmenter
On Tue, 28 Mar 2006 23:41, Joshua Parmenter wrote: Ignoring modern style sheets means not being able to type-set for those companies. Which also means using Finale or Sibelius. Or, perhaps this can be configurable. Maybe a stylesheet could be loaded? If you're new here, you may not realise tha

Re: Tremolo positioning

2006-03-28 Thread Joe Neeman
On Tue, 28 Mar 2006 23:41, Joshua Parmenter wrote: > Ignoring modern style sheets means not being able to type-set for > those companies. Which also means using Finale or Sibelius. > > Or, perhaps this can be configurable. Maybe a stylesheet could be > loaded? If you're new here, you may not realis

Re: Tremolo positioning

2006-03-28 Thread Han-Wen Nienhuys
Joshua Parmenter wrote: Ignoring modern style sheets means not being able to type-set for those companies. Which also means using Finale or Sibelius. Or, perhaps this can be configurable. Maybe a stylesheet could be loaded? Yes, of course. I was thinking of the correct default. And I apologi

Re: Tremolo positioning

2006-03-28 Thread Joshua Parmenter
Ignoring modern style sheets means not being able to type-set for those companies. Which also means using Finale or Sibelius. Or, perhaps this can be configurable. Maybe a stylesheet could be loaded? And I apologize for not introducing myself and my situation. I was directed here from a M

Re: Tremolo positioning

2006-03-28 Thread Han-Wen Nienhuys
Joshua Parmenter wrote: I'll do this tonight (when I'm home with my scanner). Looking over some older scores, I definitely see examples like the one sent earlier... but over 10 years of typesetting, most current style sheets (if memory serves me correctly) specify slanted tremolos. I'll actua

Re: Tremolo positioning

2006-03-28 Thread Joe Neeman
On Tue, 28 Mar 2006 21:26, Joshua Parmenter wrote: > I'll do this tonight (when I'm home with my scanner). > > Looking over some older scores, I definitely see examples like the > one sent earlier... but over 10 years of typesetting, most current > style sheets (if memory serves me correctly) speci

Re: Tremolo positioning

2006-03-28 Thread Joshua Parmenter
I'll do this tonight (when I'm home with my scanner). Looking over some older scores, I definitely see examples like the one sent earlier... but over 10 years of typesetting, most current style sheets (if memory serves me correctly) specify slanted tremolos. I'll actually see if I can dig u

Re: Tremolo positioning

2006-03-28 Thread Joe Neeman
On Tue, 28 Mar 2006 14:39, Joshua Parmenter wrote: > This is described in Matt Stone's book "Music Notation in the 20th > Century" (not just 20th century music notation, but the practices of > notation in the 20th century): > > "The tremolo bars should be thinner than beams, and as long or a > litt

Re: Tremolo positioning

2006-03-28 Thread Jan Nieuwenhuizen
Werner LEMBERG writes: >> "The tremolo bars should be thinner than beams, > > Urgh. Never seen that in normal scores from German publishers. I think that I have seen thicker than beams, in some publications. >> On beamed notes, the tremolo bars usually slant sightly more than >> the beams Note

Re: Tremolo positioning

2006-03-28 Thread Werner LEMBERG
> "The tremolo bars should be thinner than beams, Urgh. Never seen that in normal scores from German publishers. > On beamed notes, the tremolo bars usually slant sightly more than > the beams Note that the tremolo bars always slant upward, regardless > of beam- slant" Hmmm. > Mostly, you wan

Re: Tremolo positioning

2006-03-28 Thread Joshua Parmenter
This is described in Matt Stone's book "Music Notation in the 20th Century" (not just 20th century music notation, but the practices of notation in the 20th century): "The tremolo bars should be thinner than beams, and as long or a little longer than the width of a note-head On beamed notes

Re: Tremolo positioning

2006-03-28 Thread Han-Wen Nienhuys
Han-Wen Nienhuys wrote: Can you resend the patch using more idiomatic code? Thanks! Also, can you include a small regression test sample, so it's obvious when we break something? -- Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen LilyPond Software Design -- Code for

Re: Tremolo positioning

2006-03-28 Thread Han-Wen Nienhuys
Joe Neeman wrote: + Real height_of_my_trem = 0.0; + Grob *trem = unsmob_grob (me->get_object ("tremolo-flag")); + if (trem) + height_of_my_trem = ly_scm2interval (trem->get_property ("Y-extent")).length () +/* hack a bit of space around the trem. */ ++ beam_translation -

Re: Tremolo positioning

2006-03-27 Thread Joe Neeman
On Tue, 28 Mar 2006 07:01, Joshua Parmenter wrote: > Shouldn't all tremolo lines be at the same angle (usually about 30 > degrees)? > > Sorry, I am new to the list, and am not sure where this thread > started. But in standard notation, this is not what usual tremolo > markings look like. I started

Re: Tremolo positioning

2006-03-27 Thread Werner LEMBERG
> Shouldn't all tremolo lines be at the same angle (usually about 30 > degrees)? AFAIK, this isn't true in the presence of beams. Can you provide a counterexample (this is, a small scanned image)? In that case we have to make it configurable. Werner ___

Re: Tremolo positioning

2006-03-27 Thread Werner LEMBERG
> I've tweaked it by adding a little more to the minimum length of the > stem. The Franck output is unchanged, I've attached the new > Tchaikovsky output. Very nice! > Oh, and I remembered a ChangeLog entry this time :) Please add it just to the mail and don't include it into the diff directly.

Re: Tremolo positioning

2006-03-27 Thread Joshua Parmenter
Shouldn't all tremolo lines be at the same angle (usually about 30 degrees)? Sorry, I am new to the list, and am not sure where this thread started. But in standard notation, this is not what usual tremolo markings look like. Josh On Mar 28, 2006, at 9:48 AM, Joe Neeman wrote: On Tue,

Re: Tremolo positioning

2006-03-27 Thread Joe Neeman
On Tue, 28 Mar 2006 03:43, Werner LEMBERG wrote: > > It seems this issue doesn't bother anyone else? In any case, now > > that 2.8 is out there, I thought I'd start pushing this point again. > > I attach a patch that gives the behaviour that I think is correct. > > I also attach 2 examples of the d

Re: Tremolo positioning

2006-03-27 Thread Werner LEMBERG
> It seems this issue doesn't bother anyone else? In any case, now > that 2.8 is out there, I thought I'd start pushing this point again. > I attach a patch that gives the behaviour that I think is correct. > I also attach 2 examples of the differences between the existing and > the proposed behav

Re: Tremolo positioning

2006-03-27 Thread Joe Neeman
It seems this issue doesn't bother anyone else? In any case, now that 2.8 is out there, I thought I'd start pushing this point again. I attach a patch that gives the behaviour that I think is correct. I also attach 2 examples of the differences between the existing and the proposed behaviours.