LGTM.
http://codereview.appspot.com/3838042/diff/2002/scm/output-lib.scm
File scm/output-lib.scm (right):
http://codereview.appspot.com/3838042/diff/2002/scm/output-lib.scm#newcode238
scm/output-lib.scm:238: (let ((parent (ly:grob-parent grob 0)))
(ly:grob-parent grob X)
http://codereview.apps
On 2010/12/29 00:01:45, Neil Puttock wrote:
Looks OK, though it would be simpler to define the callback in
output-lib.scm.
I had the same idea, so that patch is already uploaded ;-) This has the
advantage that it might also be used for other grobs
http://codereview.appspot.com/3838042/
__
On 2010/12/28 23:43:46, Reinhold wrote:
Okay, new patch uploaded, which uses a callback to inherit the
OctavateEight's
break-visibility from the parent clef. This has the advantage that one
can still
override the visibility independent from the clef (although I don't
think there
is a real-l
On 2010/12/28 23:02:25, Reinhold wrote:
Hmm, I can't really think of a situation where you want to show or
hide the
octavation eight independently of the associated clef
Neither can I. :)
(actually, I never
understood why it was a separate grob in the first place).
It makes it easier to
Okay, new patch uploaded, which uses a callback to inherit the
OctavateEight's break-visibility from the parent clef. This has the
advantage that one can still override the visibility independent from
the clef (although I don't think there is a real-life use for that)
Okay to push?
http://codere
Reviewers: Neil Puttock,
Message:
On 2010/12/28 22:06:43, Neil Puttock wrote:
I'd prefer a callback to copy the Clef's setting, then it's documented
automatically (and can be changed if absolutely necessary).
Hmm, I can't really think of a situation where you want to show or hide
the octavatio
Hi Reinhold,
I'd prefer a callback to copy the Clef's setting, then it's documented
automatically (and can be changed if absolutely necessary).
Cheers,
Neil
http://codereview.appspot.com/3838042/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
