Re: Stacked extensions in harmonics

2021-03-02 Thread Valentin Petzel
No, I was talking about the thing with the parentheses I sent you before. Valentin signature.asc Description: This is a digitally signed message part.

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 6:11 pm, Valentin Petzel wrote: This is a quick mockup that still needs lots of tweaking and testing. [...] Did you mean to attach something new in that email, or was it commentary on what you already posted? I just want to make sure we are not missing any additional content or

Re: Stacked extensions in harmonics

2021-03-01 Thread Valentin Petzel
As said before, I’ve done a small testing implementation. It is not perfect, but a start. Would love any aesthetic opinion you might have on this. I’ll fork the changes into a new branch tomorrow, so you all can try them out, but I have to go to bed now, it’s far to late ... Valentin Ohne Tite

Re: Stacked extensions in harmonics

2021-03-01 Thread Valentin Petzel
This is a quick mockup that still needs lots of tweaking and testing. For example currently the width of the Parenthesis is in an order of the square root of the height of the actual markup. This should be not too bad, as we’d expect a good bracket to grow faster horizontally than vertically. Bu

Re: Stacked extensions in harmonics

2021-03-01 Thread Kieren MacMillan
Hi all, On Mar 1, 2021, at 8:33 PM, Valentin Petzel wrote: > We can probably move a lot of stuff to \parenthesize,the question is if that > is wanted, as it will be a change of the default behaviour. The fact that \parenthesize doesn’t really take its content into account has been a long-stand

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 5:33 pm, Valentin Petzel wrote: We can probably move a lot of stuff to \parenthesize,the question is if that is wanted, as it will be a change of the default behaviour. Basically one needs to do to things: → figure out the font-size and set thickness appropriately. In case the te

Re: Stacked extensions in harmonics

2021-03-01 Thread Valentin Petzel
We can probably move a lot of stuff to \parenthesize,the question is if that is wanted, as it will be a change of the default behaviour. Basically one needs to do to things: → figure out the font-size and set thickness appropriately. In case the text is bold the parentheses should probably be th

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 4:18 pm, Valentin Petzel wrote: Actually, as long as a stack of two is always larger than the Chord Symbol, we can easily do this, see example! Awesome. To my eye, that looks best. But I will happily concede to the wider audience when it comes to the default behavior, since fo

Re: Stacked extensions in harmonics

2021-03-01 Thread Valentin Petzel
Actually, as long as a stack of two is always larger than the Chord Symbol, we can easily do this, see example! Ohne Titel2.pdf Description: Adobe PDF document signature.asc Description: This is a digitally signed message part.

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 3:53 pm, Valentin Petzel wrote: I wonder if the logic for scaling parenthesis thickness should really be baked into that markup command. I could imagine users of \bracket or \parenthesize might want values to smartly scale. If that work could be refactored there, it would clean

Re: Stacked extensions in harmonics

2021-03-01 Thread Valentin Petzel
Yes, I was thinking of that too, but I left it for now. That being said, I think I can quite easily come up with something. The important thing would be: I’d have to check the height of this markup (which either needs a good approximation or simply an on-the-fly call), from there I can work out

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 3:05 pm, Valentin Petzel wrote: Yes. That was a deliberate decision, because I thought maybe it’s better that way. We simply need to change change #:general-align Y 0 to #:general-align Y -1 in line 462 for the behaviour shown in the example. Ah, I can see how your default makes

Re: Stacked extensions in harmonics

2021-03-01 Thread Valentin Petzel
Yes. That was a deliberate decision, because I thought maybe it’s better that way. We simply need to change change #:general-align Y 0 to #:general-align Y -1 in line 462 for the behaviour shown in the example. Control over the parathesis style should be no problem, we can for example have a se

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 2:34 pm, Aaron Hill wrote: On 2021-03-01 1:26 pm, Valentin Petzel wrote: Hello, I have modified the Ignatzek-ChordNameFunction to allow for stacked Extensions (as they are usually used in jazz notation). This is done by specifiying a boolean context property stackedChordExtension

Re: Stacked extensions in harmonics

2021-03-01 Thread Aaron Hill
On 2021-03-01 1:26 pm, Valentin Petzel wrote: Hello, I have modified the Ignatzek-ChordNameFunction to allow for stacked Extensions (as they are usually used in jazz notation). This is done by specifiying a boolean context property stackedChordExtensions, and can be used in such a way as show