Re: Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-26 Thread jonas . hahnfeld
On 2020/01/26 13:38:41, hanwenn wrote: > David? > > Is there a git branch that we can check out? For testing, I think it's > better than downloading patches from rietveld. Well, maybe read https://lists.gnu.org/archive/html/lilypond-devel/2020-01/msg00415.html ? https://codereview.appspot.com/55

Re: Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-26 Thread Han-Wen Nienhuys
David? Is there a git branch that we can check out? For testing, I think it's better than downloading patches from rietveld. On Sun, Jan 26, 2020 at 2:31 PM wrote: > > On 2020/01/26 13:27:25, hanwenn wrote: > > what is the status of your work? > > I think it's ready for Python 3.5 and passes ch

Re: Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-26 Thread jonas . hahnfeld
On 2020/01/26 13:27:25, hanwenn wrote: > what is the status of your work? I think it's ready for Python 3.5 and passes check & doc on my system. But with nobody responding on lilypond-devel I'm not sure how to proceed... https://codereview.appspot.com/553430047/

Re: Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-26 Thread hanwenn
On 2020/01/26 13:27:25, hanwenn wrote: > what is the status of your work? leaving Jonas to take care of this. https://codereview.appspot.com/553430047/

Re: Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-26 Thread hanwenn
Reviewers: lemzwerg, hahnjo, Message: what is the status of your work? Description: Some py3 fixes * 0777 should be spelled as 0o777. We omit it as it is the mkdir default. * print needs parentheses. Use sys.stderr.write instead. Please review this at https://codereview.appspot.com/5534300

Re: Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-26 Thread jonas . hahnfeld
While probably correct, I strongly object to this patch. I've been working on migration to Python 3 for the last few months and I proposed to switch over to Python 3 entirely in December. Please at least take a look https://sourceforge.net/p/testlilyissues/issues/5646/ https://codereview.appspot.c

Some py3 fixes (issue 553430047 by hanw...@gmail.com)

2020-01-25 Thread lemzwerg--- via Discussions on LilyPond development
LGTM https://codereview.appspot.com/553430047/diff/573430051/python/lilylib.py File python/lilylib.py (right): https://codereview.appspot.com/553430047/diff/573430051/python/lilylib.py#newcode257 python/lilylib.py:257: sys.stderr.write('command failed: %s\n' % cmd) With space before the '(' or w