Re: Skylines: reject steep-sloped buildings; issue 3383 (issue 9890045)

2013-06-04 Thread David Kastrup
"Keith OHara" writes: > On Mon, 03 Jun 2013 12:03:26 -0700, wrote: > > I was able to figure out the old comment, once I realized it explained > the reason for the line it is one, while referring to the following > lines. I'll remove this change. > >> https://codereview.appspot.com/9890045/diff/

Re: Skylines: reject steep-sloped buildings; issue 3383 (issue 9890045)

2013-06-03 Thread Keith OHara
On Mon, 03 Jun 2013 12:03:26 -0700, wrote: https://codereview.appspot.com/9890045/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/9890045/diff/1/lily/skyline.cc#newcode117 lily/skyline.cc:117: slope_ = 0.0; /* if they were both infinite, we would get nan, no

Re: Skylines: reject steep-sloped buildings; issue 3383 (issue 9890045)

2013-06-03 Thread dak
https://codereview.appspot.com/9890045/diff/1/lily/skyline.cc File lily/skyline.cc (right): https://codereview.appspot.com/9890045/diff/1/lily/skyline.cc#newcode117 lily/skyline.cc:117: slope_ = 0.0; /* if they were both infinite, we would get nan, not 0, from the next line */ That comment is a

Skylines: reject steep-sloped buildings; issue 3383 (issue 9890045)

2013-05-31 Thread lemzwerg
LGTM. https://codereview.appspot.com/9890045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel