On Oct 29, 2011, at 9:00 AM, d...@gnu.org wrote:
>>
>
> Patch has been backed out. It broke the documentation build this
> morning. And it broke the documentation build with a line that Neil has
> already pointed out yesterday at noon. It is not that this particular
> mistake was unheard of.
On 2011/10/28 13:26:22, mike_apollinemike.com wrote:
On Oct 28, 2011, at 3:24 PM, mailto:n.putt...@gmail.com wrote:
>
>
http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly
> File input/regression/footnote-break-visibility.ly (left):
>
>
http://co
On Oct 28, 2011, at 3:24 PM, n.putt...@gmail.com wrote:
>
> http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly
> File input/regression/footnote-break-visibility.ly (left):
>
> http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-b
http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly
File input/regression/footnote-break-visibility.ly (left):
http://codereview.appspot.com/5293053/diff/11005/input/regression/footnote-break-visibility.ly#oldcode1
input/regression/footnote-break-visibi
On Sat, Oct 22, 2011 at 09:56:16PM +0200, m...@apollinemike.com wrote:
>
> Running fix-cc.py, I got:
> astyle wasn't in the lilydev Ubuntu, so I used apt-get to get
> it. Maybe there's a problem with versioning?
You need version 2.02. It would be nice if the script warned if
you had a differen
On Oct 22, 2011, at 1:08 AM, percival.music...@gmail.com wrote:
>
> http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
> File lily/page-breaking.cc (right):
>
> http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189
> lily/page-breaking.cc:189: old
On 2011/10/21 23:49:26, Bertrand Bordage wrote:
Sorry for this total mistake. !ly_is_equal (..., SCM_EOL) should do
it, then.
It is pretty pointless to use ly_is_equal instead of scm_is_eq on
SCM_EOL, and !scm_is_null (...) is prettier anyway.
http://codereview.appspot.com/5293053/
_
Sorry for this total mistake. !ly_is_equal (..., SCM_EOL) should do it,
then.
http://codereview.appspot.com/5293053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g->get_property
("footnote-stencil") !=
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g->get_property
("footnote-stencil") !=
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
File lily/page-breaking.cc (right):
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189
lily/page-breaking.cc:189: old.in_note_heights_.begin (),
old.in_note_heights_.end ());
Why are we talking
A small comment to show you a possible solution for the indentation.
This can be apply at every "line length" comment.
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
File lily/page-breaking.cc (right):
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.c
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc#newcode79
lily/page-layout-problem.cc:79: footnotes_added = g->get_property
("footnote-stencil") !=
I'm not sure how to deal with some of the "déBordage" of line lengths -
you're right that they're ugly, but I dont' see how to chop them down &
stay within good code style.
Thanks for the review!
~Mike
http://codereview.appspot.com/5293053/diff/12001/lily/page-layout-problem.cc
File lily/page-l
I can't compile because of valgrind.
Bertrand
http://codereview.appspot.com/5293053/diff/12001/lily/include/page-layout-problem.hh
File lily/include/page-layout-problem.hh (right):
http://codereview.appspot.com/5293053/diff/12001/lily/include/page-layout-problem.hh#newcode100
lily/include/page
Hey all,
The patch is now ready to be tested - I got a clean bill of health from
the regtests.
Cheers,
MS
http://codereview.appspot.com/5293053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-de
The memory management issue is now fixed.
A new patch will be coming down the pipe in 2-3 hours with a regtest.
Cheers,
MS
http://codereview.appspot.com/5293053/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/list
Reviewers: ,
Message:
Hey all,
As part of project markup & at the suggestion of Nicolas Sceaux by way
of Valentin's opera, I've implemented in-notes in LilyPond. These notes
hover above systems and come up a fair bit in vocal music.
It works, but I have one major and one semi-major snag that I
18 matches
Mail list logo
