On Sat, Jul 25, 2009 at 7:03 PM, wrote:
> On 2009/07/24 23:30:00, Patrick McCarty wrote:
>
>> The new code uses a generalized regular expression that will match a
>> element with attributes in any order.
>> The code is slower now, I think due to the complexity of the new regular
>> expression. I
It seems as though rietveld wants to send my code-comments and my
reply-to-comments comments in two separate emails. Sorry for the noise.
http://codereview.appspot.com/96083/diff/1015/20
File lily/pango-font.cc (right):
http://codereview.appspot.com/96083/diff/1015/20#newcode354
Line 354: bool
On 2009/07/24 23:30:00, Patrick McCarty wrote:
On 2009/07/21 18:43:10, joeneeman wrote:
> I think it would be helpful if you gave an example or 2 of the sort
of string
> you expect to match here. I'm a bit worried also about the fact that
you
require
> the attributes to be in a specific order
be in a specific order.
The new code uses a generalized regular expression that will match a
element with attributes in any order.
The code is slower now, I think due to the complexity of the new regular
expression. It might be a better idea if I rewrite this in C++
eventually.
Description:
SVG bac
http://codereview.appspot.com/96083/diff/1/8
File lily/pango-font.cc (right):
http://codereview.appspot.com/96083/diff/1/8#newcode351
Line 351: // options.
Could you please have a look at this? (after applying this patch, if you
prefer). The more special cases we add for different backends, the
Hello,
I've uploaded a new patchset related to the SVG backend:
http://codereview.appspot.com/96083/show
The several examples I am using as test cases can be found on this page:
http://uoregon.edu/~pmccarty/svg/
They reflect the output created with the above patchset.
***
Right now, only the
