LGTM.
Thanks
http://codereview.appspot.com/1991043/show
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Am 04.05.2010 um 14:39 schrieb David Kastrup:
> Carl Sorensen writes:
>
>> I like the thought of just switching to another developer's branch to
>> review, instead of creating my own branch, applying the patch, and
>> then testing.
>
> Well, unless the patch fails, there is not much of a diffe
On 5/4/10 6:39 AM, "David Kastrup" wrote:
> Carl Sorensen writes:
>
>> I like the thought of just switching to another developer's branch to
>> review, instead of creating my own branch, applying the patch, and
>> then testing.
>
> Well, unless the patch fails, there is not much of a differ
Carl Sorensen writes:
> On 5/4/10 12:46 AM, "David Kastrup" wrote:
>
>> Carl Sorensen writes:
>>
>>
>>> This is a serious question I'd like to ask you. If you were the king
>>> of LilyPond, what would you establish as the workflow? I'd really
>>> like to hear your opinion.
>>
>> I'd not pr
Carl Sorensen writes:
> I like the thought of just switching to another developer's branch to
> review, instead of creating my own branch, applying the patch, and
> then testing.
Well, unless the patch fails, there is not much of a difference. For
divergent development, however, it might help t
On 5/4/10 12:58 AM, "Werner LEMBERG" wrote:
>
>
>>> This is a serious question I'd like to ask you. If you were the
>>> king of LilyPond, what would you establish as the workflow? I'd
>>> really like to hear your opinion.
>>
>> I'd not prohibit any work flow that can be maintained with
>>
On 5/4/10 12:46 AM, "David Kastrup" wrote:
> Carl Sorensen writes:
>
>
>> This is a serious question I'd like to ask you. If you were the king
>> of LilyPond, what would you establish as the workflow? I'd really
>> like to hear your opinion.
>
> I'd not prohibit any work flow that can be
Reinhold Kainhofer writes:
> Am Dienstag, 4. Mai 2010 10:51:05 schrieb David Kastrup:
>> Contained patch sets can be reasonably well exchanged by mail/mailing
>> list.
>
> My experience with this is that patches sent by mail will be forgotten the
> next day. So, either you are lucky to get a res
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am Dienstag, 4. Mai 2010 10:51:05 schrieb David Kastrup:
> Contained patch sets can be reasonably well exchanged by mail/mailing
> list.
My experience with this is that patches sent by mail will be forgotten the
next day. So, either you are lucky to
Reinhold Kainhofer writes:
> Am Dienstag, 4. Mai 2010 09:18:48 schrieb David Kastrup:
>> Not
>> everybody has access to a git server of his own, so a standard hosting
>> solution would certainly be welcome.
>
> Ever heard of repo.or.cz??? (Of course, you need to create an account there,
> too.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Am Dienstag, 4. Mai 2010 09:18:48 schrieb David Kastrup:
> Not
> everybody has access to a git server of his own, so a standard hosting
> solution would certainly be welcome.
Ever heard of repo.or.cz??? (Of course, you need to create an account ther
Werner LEMBERG writes:
>>> This is a serious question I'd like to ask you. If you were the
>>> king of LilyPond, what would you establish as the workflow? I'd
>>> really like to hear your opinion.
>>
>> I'd not prohibit any work flow that can be maintained with
>> single-line git commands. Th
>> This is a serious question I'd like to ask you. If you were the
>> king of LilyPond, what would you establish as the workflow? I'd
>> really like to hear your opinion.
>
> I'd not prohibit any work flow that can be maintained with
> single-line git commands. That includes posting patch seri
gy for
>> merging/rebasing for anybody without a branch history. So the only
>> person able to work on this will be yourself. People will be able to
>> check your work only when the patch set applies. But that means that
>> mainline changes in the same areas need to be t
gt; branch history. So the only person able to work on this will be
> yourself. People will be able to check your work only when the patch
> set applies. But that means that mainline changes in the same areas
> need to be tracked by you and will also pollute the Rietveld review
> area
15 matches
Mail list logo
