Re: Rewrite the vertical layout of staves/systems.

2009-07-27 Thread Han-Wen Nienhuys
On Mon, Jul 27, 2009 at 6:32 PM, Han-Wen Nienhuys wrote: >>> http://codereview.appspot.com/97119/diff/1/22 >>> File lily/staff-grouper-engraver.cc (right): >>> >>> http://codereview.appspot.com/97119/diff/1/22#newcode21 >>> Line 21: { >>> Are engravers allowed to inherit code from other classes? >>

Re: Rewrite the vertical layout of staves/systems.

2009-07-27 Thread Han-Wen Nienhuys
On Mon, Jul 27, 2009 at 3:51 PM, Joe Neeman wrote: > On Mon, 2009-07-27 at 05:42 +, pnor...@gmail.com wrote: >> I don't really understand the code from this patchset, but I just have >> one quick comment. >> http://codereview.appspot.com/97119/diff/1/22 >> File lily/staff-grouper-engraver.cc (

Re: Rewrite the vertical layout of staves/systems.

2009-07-27 Thread Joe Neeman
On Mon, 2009-07-27 at 05:42 +, pnor...@gmail.com wrote: > I don't really understand the code from this patchset, but I just have > one quick comment. > > Thanks, > Patrick > > > http://codereview.appspot.com/97119/diff/1/22 > File lily/staff-grouper-engraver.cc (right): > > http://coderevie

Rewrite the vertical layout of staves/systems.

2009-07-26 Thread pnorcks
I don't really understand the code from this patchset, but I just have one quick comment. Thanks, Patrick http://codereview.appspot.com/97119/diff/1/22 File lily/staff-grouper-engraver.cc (right): http://codereview.appspot.com/97119/diff/1/22#newcode21 Line 21: { Are engravers allowed to inher