Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-14 Thread dak
On 2020/04/13 17:43:17, hanwenn wrote: > > Actually, it looks like I have been measuring noise. Thermal throttling? > > It looks like I can get reproducible timings if I downclock the CPU from 2.6 to > 2.0Ghz Put the following line in the config /etc/modprobe.d/acpi.conf:options thinkpad-acpi

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread dak
On 2020/04/13 21:13:42, hanwenn wrote: > > > > You need to sort the C++ structures potentially accessed by the GC hook into a > > Preinit class (grep for Preinit for existing uses) and inherit from that > before > > inheriting from whatever operates the Smob. Then C++ guarantees an > > initialis

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
https://codereview.appspot.com/575990043/diff/577740043/lily/mutable-properties.cc File lily/mutable-properties.cc (right): https://codereview.appspot.com/575990043/diff/577740043/lily/mutable-properties.cc#newcode50 lily/mutable-properties.cc:50: if (SCM_EQ_P (key (i), k)) On 2020/04/13 20:21:2

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
On 2020/04/13 20:26:10, dak wrote: > On 2020/04/13 20:21:29, dak wrote: > > > > https://codereview.appspot.com/575990043/diff/577740043/lily/mutable-properties.cc#newcode109 > > lily/mutable-properties.cc:109: Mutable_properties::mark () const > > This can segfault in GUILEv2 and/or depending on s

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread dak
On 2020/04/13 20:21:29, dak wrote: > https://codereview.appspot.com/575990043/diff/577740043/lily/mutable-properties.cc#newcode109 > lily/mutable-properties.cc:109: Mutable_properties::mark () const > This can segfault in GUILEv2 and/or depending on some other circumstances since > the C++ members

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread dak
https://codereview.appspot.com/575990043/diff/577740043/lily/mutable-properties.cc File lily/mutable-properties.cc (right): https://codereview.appspot.com/575990043/diff/577740043/lily/mutable-properties.cc#newcode50 lily/mutable-properties.cc:50: if (SCM_EQ_P (key (i), k)) scm_is_eq https://co

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
On 2020/04/13 17:43:17, hanwenn wrote: > On 2020/04/13 17:17:31, hanwenn wrote: > > On 2020/04/13 16:58:41, hanwenn wrote: > > > On 2020/04/13 16:40:34, hahnjo wrote: > > > > I gave this patch a try on my system, time lilypond MSDM.ly, 'real' time, > 3 > > > > repetitions > > > > > > > > baseline

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
On 2020/04/13 17:17:31, hanwenn wrote: > On 2020/04/13 16:58:41, hanwenn wrote: > > On 2020/04/13 16:40:34, hahnjo wrote: > > > I gave this patch a try on my system, time lilypond MSDM.ly, 'real' time, 3 > > > repetitions > > > > > > baseline (master, 0e7c26d40f): > > > 0m42,533s; 0m42,547s; 0m42,

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
On 2020/04/13 16:58:41, hanwenn wrote: > On 2020/04/13 16:40:34, hahnjo wrote: > > I gave this patch a try on my system, time lilypond MSDM.ly, 'real' time, 3 > > repetitions > > > > baseline (master, 0e7c26d40f): > > 0m42,533s; 0m42,547s; 0m42,430s > > > > Abstract Grob property storage into Mut

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread jonas . hahnfeld
On 2020/04/13 16:58:41, hanwenn wrote: > On 2020/04/13 16:40:34, hahnjo wrote: > > I gave this patch a try on my system, time lilypond MSDM.ly, 'real' time, 3 > > repetitions > > > > baseline (master, 0e7c26d40f): > > 0m42,533s; 0m42,547s; 0m42,430s > > > > Abstract Grob property storage into Mut

Re: Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread hanwenn
Reviewers: hahnjo, Message: On 2020/04/13 16:40:34, hahnjo wrote: > I gave this patch a try on my system, time lilypond MSDM.ly, 'real' time, 3 > repetitions > > baseline (master, 0e7c26d40f): > 0m42,533s; 0m42,547s; 0m42,430s > > Abstract Grob property storage into Mutable_properties. > (https:

Rewrite Mutable_properties based on vector (issue 575990043 by hanw...@gmail.com)

2020-04-13 Thread jonas . hahnfeld
I gave this patch a try on my system, time lilypond MSDM.ly, 'real' time, 3 repetitions baseline (master, 0e7c26d40f): 0m42,533s; 0m42,547s; 0m42,430s Abstract Grob property storage into Mutable_properties. (https://codereview.appspot.com/561640043) 0m41,102s; 0m41,036s; 0m40,861s Rewrite Mutabl