Re: Remove head- and foot-separation. (issue3199041)

2010-11-21 Thread markpolesky
On 2010/11/20 08:44:51, Trevor Daniels wrote: LGTM Patch pushed and issue closed. http://codereview.appspot.com/3199041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Remove head- and foot-separation. (issue3199041)

2010-11-20 Thread tdanielsmusic
LGTM http://codereview.appspot.com/3199041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Remove head- and foot-separation. (issue3199041)

2010-11-20 Thread markpolesky
On 2010/11/20 01:23:07, Keith wrote: Misplaced underscore tag for translation? Oops. Fixed, thanks. On 2010/11/20 00:12:19, Graham Percival wrote: I would rather wait another 23.5 hours, to give people in all timezones (regardless of geographic location; I'm living in Pacific Standard Time a

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread k-ohara5a5a
http://codereview.appspot.com/3199041/diff/10001/python/convertrules.py File python/convertrules.py (right): http://codereview.appspot.com/3199041/diff/10001/python/convertrules.py#newcode3101 python/convertrules.py:3101: stderr_write("Adjust settings for top-system-spacing instead.\n") Misplace

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread percival . music . ca
On 2010/11/19 23:23:20, Mark Polesky wrote: Okay, this small patch is finished. Graham, would you like me to wait to push this for any reason? The patch looks ok to me. I agree with the 2.13.40 convert-ly rule, and the NOT_SMART-ness. At the moment, I can't think of any reason why somebody w

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread markpolesky
Okay, this small patch is finished. Graham, would you like me to wait to push this for any reason? - Mark http://codereview.appspot.com/3199041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread pnorcks
On 2010/11/19 10:06:33, perpeduumimmobile wrote: On 2010/11/19 07:55:46, Patrick McCarty wrote: > IIUC, this would not be a straightforward conversion that regular > expressions can (easily) deal with. I would suggest a NOT SMART > rule that recommends the use of the new spacing alists. I sec

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread pnorcks
On 2010/11/19 17:26:49, Mark Polesky wrote: On 2010/11/19 07:55:46, Patrick McCarty wrote: > I would suggest a NOT SMART rule that recommends the > use of the new spacing alists. At which release point should this rule be entered? This commit was pushed 2.13.4: 2f38710 Rewrite the vertical la

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread markpolesky
On 2010/11/19 07:55:46, Patrick McCarty wrote: I would suggest a NOT SMART rule that recommends the use of the new spacing alists. At which release point should this rule be entered? This commit was pushed 2.13.4: 2f38710 Rewrite the vertical layout of staves/systems. - Mark http://coderevie

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread markpolesky
On 2010/11/19 07:55:46, Patrick McCarty wrote: I would suggest a NOT SMART rule that recommends the use of the new spacing alists. At which release point should this rule be entered? This commit was pushed 2.13.4: 2f38710 Rewrite the vertical layout of staves/systems. - Mark http://coderevie

Re: Remove head- and foot-separation. (issue3199041)

2010-11-19 Thread perpeduumimmobile
On 2010/11/19 07:55:46, Patrick McCarty wrote: IIUC, this would not be a straightforward conversion that regular expressions can (easily) deal with. I would suggest a NOT SMART rule that recommends the use of the new spacing alists. I second this. It would be possible to convert the *-separat

Re: Remove head- and foot-separation. (issue3199041)

2010-11-18 Thread pnorcks
On 2010/11/19 07:02:35, Mark Polesky wrote: When they ceased to be, the functionality they provided was presumably achievable using the new spacing alists, but a convert-ly rule to automate this was never written. IIUC, this would not be a straightforward conversion that regular expressions can

Re: Remove head- and foot-separation. (issue3199041)

2010-11-18 Thread markpolesky
On 2010/11/18 17:51:55, Graham Percival wrote: I'm getting a bit confused with all the renamings, reorganizations, etc., and I can't be the only one. Could we slow things down slightly? I'd like to see only one spacing patch "on the table" at once, and leaving 24 hours after the final draft of

Re: Remove head- and foot-separation. (issue3199041)

2010-11-18 Thread percival . music . ca
On 2010/11/18 09:12:23, Mark Polesky wrote: Is that precisely how the conversion should be made? Can someone verify this? Should I push this patch or wait for a convert-ly rule? I'm getting a bit confused with all the renamings, reorganizations, etc., and I can't be the only one. Could we sl

Remove head- and foot-separation. (issue3199041)

2010-11-18 Thread markpolesky
Reviewers: , Message: If I understand correctly, head-separation and foot-separation are gone. This patch just removes the vestiges from scm/ and ly/, but I suppose we should provide a convert-ly rule? So, in an earlier patch by Alexander... http://codereview.appspot.com/1710046/diff/19001/Docu