LGTM
https://codereview.appspot.com/235790043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2015/05/01 01:22:57, Dan Eble wrote:
On 2015/05/01 00:44:45, dak wrote:
> I am not going to put in an explanation for every definition of
equal_p for
some
> smob class.
OK, that makes sense now.
> > invoked as T* t = ly_unsmob(target);
>
> I don't think that warrants a template functio
On 2015/05/01 00:44:45, dak wrote:
I am not going to put in an explanation for every definition of
equal_p for some
smob class.
OK, that makes sense now.
> invoked as T* t = ly_unsmob(target);
I don't think that warrants a template function of its own. It just
makes
matters murkier wi
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh
File lily/include/listener.hh (left):
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh#oldcode84
lily/include/listener.hh:84: Listener (Listener const &other);
On 2015/05/01 00:22:09, Dan Eble wrote:
I have reviewed the changes to smob and listener.
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh
File lily/include/listener.hh (left):
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh#oldcode84
lily/include/listener.hh:84: Listener (Listener con
Reviewers: benko.pal,
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh
File lily/include/listener.hh (right):
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh#newcode27
lily/include/listener.hh:27: register a method as an event handler in a
dispat
looks exciting to me; my only comment is about a comment
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh
File lily/include/listener.hh (right):
https://codereview.appspot.com/235790043/diff/1/lily/include/listener.hh#newcode27
lily/include/listener.hh:27: register a met
