Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-30 Thread James
Paul, On 30 January 2014 14:14, Paul Morris wrote: > I have uploaded the patches to the issue tracker. Would someone please > push? > (I don't have push access.) Thanks in advance. -Paul > > https://code.google.com/p/lilypond/issues/detail?id=3818 > > > > Tis done. Many thanks. James _

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-30 Thread Paul Morris
I have uploaded the patches to the issue tracker. Would someone please push? (I don't have push access.) Thanks in advance. -Paul https://code.google.com/p/lilypond/issues/detail?id=3818 -- View this message in context: http://lilypond.1069038.n5.nabble.com/stencil-scm-add-make-path-stenci

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-23 Thread paul
On 2014-01-23 15:50, Trevor Daniels wrote: Yes. Go to the issue tracker 3818, click in the box at the bottom to enter a comment, and set the label Patch-countdown to Patch-new, and save. Ah, that makes sense, thanks. However, when I start to enter a comment I don't see any interface for edi

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-23 Thread Trevor Daniels
Paul Morris wrote Thursday, January 23, 2014 10:44 PM > This second patch set appeared successfully on Rietveld, but it looks like > the automatic test to confirm that it passes make, make check, and make docs > was not triggered: > http://code.google.com/p/lilypond/issues/detail?id=3818 > > So

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-23 Thread Urs Liska
Am 23.01.2014 23:44, schrieb Paul Morris: paulwmorris wrote On 2014/01/18 04:52:51, lemzwerg wrote: A minor thing: We use two spaces after a full stop in documentation strings. (At least it should be like that in general.) Done. https://codereview.appspot.com/54050043/ This second patch se

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-23 Thread Paul Morris
paulwmorris wrote > On 2014/01/18 04:52:51, lemzwerg wrote: >> A minor thing: We use two spaces after a full stop in documentation >> strings. >> (At least it should be like that in general.) > > Done. > > https://codereview.appspot.com/54050043/ This second patch set appeared successfully on Ri

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-20 Thread paulwmorris
https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm#newcode449 scm/stencil.scm:449: coordinates for the origin point of the path (used for closepath and On 2014/01/18 04:52:51, lemzwerg wrote:

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-18 Thread paulwmorris
On 2014/01/18 04:52:50, lemzwerg wrote: https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/54050043/diff/1/scm/stencil.scm#newcode449 scm/stencil.scm:449: coordinates for the origin point of the path (used for closepat

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-18 Thread paulwmorris
Reviewers: , Message: This patch introduces a make-path-stencil function that offers the benefits of the current make-connected-path-stencil function without its limitations: - Like make-connected-path-stencil it automatically calculates the stencil extents so you don't have to do it manually (n

Re: stencil.scm: add make-path-stencil function (issue 54050043)

2014-01-17 Thread Paul Morris
The message below appeared fine on Rietveld but hasn't come through on the dev list after about 45 minutes, probably because the email address for my google account was not subscribed to the list. So here it is. Thanks, -Paul Reviewers: , Message: This patch introduces a make-path-stencil funct