>> > Ah, so this is a by-the-way fix. Can it be in a separate commit, please?
>
>> it is; I meant to note it but forgot, sorry. is there interest in pushing
>> such
>> multi-commit patches to some dev branch?
>
> If there is, people should ask. Substructuring an issue into several
> logical com
On 2012/10/24 10:36:52, benko.pal wrote:
[...]
> Ah, so this is a by-the-way fix. Can it be in a separate commit,
please?
it is; I meant to note it but forgot, sorry. is there interest in
pushing such
multi-commit patches to some dev branch?
If there is, people should ask. Substructurin
On Wed, Oct 24, 2012 at 12:36 PM, Benkő Pál wrote:
>>> in C++ there should be a good reason to pass complex structures like
>>> std::vector by value, not by reference to const; in this case
>>> there's no such reason, pass-by-reference works perfectly.
>>
>> Ah, so this is a by-the-way fix. Can i
>> in C++ there should be a good reason to pass complex structures like
>> std::vector by value, not by reference to const; in this case
>> there's no such reason, pass-by-reference works perfectly.
>
> Ah, so this is a by-the-way fix. Can it be in a separate commit, please?
it is; I meant to not
hi Pal,
On Tue, Oct 23, 2012 at 8:56 PM, wrote:
> in C++ there should be a good reason to pass complex structures like
> std::vector by value, not by reference to const; in this case
> there's no such reason, pass-by-reference works perfectly.
Ah, so this is a by-the-way fix. Can it be in a se
hi Janek,
Pal, could you add some comments and a more descriptive commit
message? I see
the code, and it seems to make sense, but i don't understand the
"why's". For
example, why the parameters should be passed in a different way?
in C++ there should be a good reason to pass complex stru
(as you may know, i dedicate all my code reviews to Graham the
Magnificent :D)
Pal, could you add some comments and a more descriptive commit message?
I see the code, and it seems to make sense, but i don't understand the
"why's". For example, why the parameters should be passed in a
different w
