Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-26 Thread Janek WarchoĊ‚
On Wed, Sep 26, 2012 at 8:58 AM, wrote: > In short, instead of a cryptic error message and dubious error recovery, > the user gets a human-understandable error message and a recovery more > likely not to cause follow-up errors. Ok. I supposed this was the case, but wanted to be sure. I don't t

Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-25 Thread dak
Reviewers: lemzwerg, joeneeman, janek, Message: On 2012/09/26 05:35:16, janek wrote: David wrote: > ...and where the semantics indeed require a plain string, > an error is generated explicitly in the action instead > of leaving it to the parser to complain about bad grammar. I'm not sure i un

Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-25 Thread janek . lilypond
David wrote: ...and where the semantics indeed require a plain string, an error is generated explicitly in the action instead of leaving it to the parser to complain about bad grammar. I'm not sure i understand. Does this mean that in some situations there will be errors that were not present

Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-25 Thread joeneeman
lgtm http://codereview.appspot.com/6542057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel