Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Graham Percival
On Fri, Jun 24, 2011 at 07:49:02PM +0200, Matthias Kilian wrote: > [slightly offtopic tab size rant ;-)] > > On Fri, Jun 24, 2011 at 04:44:21PM +0100, Graham Percival wrote: > > In the old/bad style that emacs produced, one tab was used to > > represent 8 spaces. Yes, it was doubly confusing. >

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Matthias Kilian
[slightly offtopic tab size rant ;-)] On Fri, Jun 24, 2011 at 04:44:21PM +0100, Graham Percival wrote: > In the old/bad style that emacs produced, one tab was used to > represent 8 spaces. Yes, it was doubly confusing. Well, no. People and/or editors who used one tab per indentation level (and p

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Graham Percival
On Fri, Jun 24, 2011 at 01:38:21PM +, Benjamin Peterson wrote: > oco.net> writes: > > > The bad news is, you replaced tabs by 4 columns when we needed 8 column. > > The good news is, so far as I can see, there were no un-wanted changes > > (no cases were we needed a literal tab). > > But th

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Reinhold Kainhofer
Am Freitag, 24. Juni 2011, 15:38:21 schrieb Benjamin Peterson: > oco.net> writes: > > The bad news is, you replaced tabs by 4 columns when we needed 8 column. > > The good news is, so far as I can see, there were no un-wanted changes > > (no cases were we needed a literal tab). > > But the GOP s

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Benjamin Peterson
oco.net> writes: > > The bad news is, you replaced tabs by 4 columns when we needed 8 column. > The good news is, so far as I can see, there were no un-wanted changes > (no cases were we needed a literal tab). But the GOP says "use 4 spaces per indentation level"! > > http://codereview.appsp

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread pkx166h
Thanks Keith and Carl. Pushed as 20596e17d6f8026f7199c9ae0e5f03517631a66c Closing this issue http://codereview.appspot.com/4627062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-23 Thread Carl . D . Sorensen
LGTM http://codereview.appspot.com/4627062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-23 Thread pkx166h
Reviewers: Keith, Message: Second go. Thanks Keith. Description: Replace Tab with 8 Spaces for .py files As per GOP Prop 1 - Python formatting. All files in /python/ and /scripts/ were checked. Please review this at http://codereview.appspot.com/4627062/ Affected files: M python/convertrul