On Thu, Oct 28, 2010 at 7:15 AM, wrote:
> There should be a space between "pitchnames" and "(ly:assoc-get"
Wow, nice catch!
Pfew. Pushed and (hopefully) closed.
Thanks everybody; now comes the documentation work!
Cheers,
Valentin.
___
lilypond-devel
Looks pretty good to me. Just a tiny style nitpick indicated below.
Thanks for your work on this!
Regards,
Patrick
http://codereview.appspot.com/2699041/diff/33001/input/regression/note-names.ly
File input/regression/note-names.ly (right):
http://codereview.appspot.com/2699041/diff/33001/inp
LGTM
http://codereview.appspot.com/2699041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Greetings everybody,
updated patch set.
Something keeps removing traling newlines at the end of files, I'm not
sure what does that (I have configured git core.whitespace properly,
though: could git cl or codereview be the culprit?).
On Wed, Oct 27, 2010 at 9:08 AM, wrote:
> That sentence has a
Looks good!
See my comments on the UTF-8 characters in the names getting mangled.
Thanks,
Carl
http://codereview.appspot.com/2699041/diff/24001/ly/norsk.ly
File ly/norsk.ly (right):
http://codereview.appspot.com/2699041/diff/24001/ly/norsk.ly#newcode4
ly/norsk.ly:4: Copyright (C) 1998-
On 2010/10/27 00:48:09, Valentin Villenave wrote:
Greetings everybody,
new patch set. Please have a look!
\version statements: I have put 2.13.38 in the regtest, but 2.14.0 in
the .ly
init files. Putting a minor version number in these files just didn't
feel
right. And 2.14 is near, is
Looks mostly good.
http://codereview.appspot.com/2699041/diff/24001/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/2699041/diff/24001/Documentation/changes.tely#newcode74
Documentation/changes.tely:74: be used in safe mode). The old syntax is
Greetings everybody,
new patch set. Please have a look!
\version statements: I have put 2.13.38 in the regtest, but 2.14.0 in
the .ly init files. Putting a minor version number in these files just
didn't feel right. And 2.14 is near, isn't it? (Color me optimistic.
:-)
The only change that I d
Hi Valentin,
I think this a great improvement on the last patch. Once you've sorted
out the nitpicks, it should be good to go.
Cheers,
Neil
http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly
File input/regression/note-names.ly (right):
http://codereview.appspot.co
2010/10/25 :
> Third time's a charm
Congrats!
--
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Congratulations, Valentin, you're on to a winner now!
I've no comments to add to those already made.
Trevor
http://codereview.appspot.com/2699041/diff/9001/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/2699041/diff/9001/Documentation/change
It's not _the_ charm, but it's certainly much more charming. Calm down,
take your time, and make it beautiful. I'm not going to start the 2.14
release candidate without this patch, so there's no rush.
Expect to do 1-3 more candidate patches before it's finally accepted.
http://codereview.apps
> \language italiano (like \clef treble) is very consistent. So
> you've convinced me that a string argument is OK.
Mhmm, in the documentation, please use
\language "italiano"
instead. Even newcomers must get used to it...
Werner
___
lilypo
http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly
File input/regression/note-names.ly (right):
http://codereview.appspot.com/2699041/diff/9001/input/regression/note-names.ly#newcode8
input/regression/note-names.ly:8: \version "2.13.37"
I prefer having \version statem
On 10/24/10 8:17 PM, "Valentin Villenave" wrote:
> On Mon, Oct 25, 2010 at 3:57 AM, wrote:
>> Update the \version string in all of these files!
>
> Well, I was reluctant to put a minor version number. Do you think
> putting "2.14.0" would be okay?
>
>> Then, the argument to your music functio
On Mon, Oct 25, 2010 at 3:57 AM, wrote:
> Update the \version string in all of these files!
Well, I was reluctant to put a minor version number. Do you think
putting "2.14.0" would be okay?
> Then, the argument to your music function would not be a string, but
> rather a symbol:
>
> \language #
I like this a lot -- it's looking like real lilypond code, instead of a
hack.
Thanks for doing this!
Carl
http://codereview.appspot.com/2699041/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
http://codereview.appspot.com/2699041/diff/1/Documentation/changes.tely#n
17 matches
Mail list logo
