Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-07-01 Thread hanwenn
http://codereview.appspot.com/4527086/diff/31002/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/4527086/diff/31002/scm/output-lib.scm#newcode798 scm/output-lib.scm:798: (define-public (glissando::before-line-breaking grob) before/after-linebreaking methods shou

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-07-01 Thread mtsolo
On 2011/07/01 02:28:46, Colin Campbell wrote: Added issue 1728 to tracker Thanks for the comments & regtest checking. Pushed as 4e55f40a1bf65633fedc62d09d91d8e3c0247efe. Cheers, MS http://codereview.appspot.com/4527086/ ___ lilypond-devel mailing l

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-30 Thread ColinPKCampbell
Added issue 1728 to tracker http://codereview.appspot.com/4527086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-30 Thread pkx166h
On 2011/06/30 15:22:18, mike_apollinemike.com wrote: On Jun 30, 2011, at 5:07 PM, mailto:n.putt...@gmail.com wrote: > LGTM, but needs a rebase to remove the changes in >Documentation/contributor/issues.itexi. > > > http://codereview.appspot.com/4527086/diff/30001/input/regression/glissan

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-30 Thread m...@apollinemike.com
On Jun 30, 2011, at 5:07 PM, n.putt...@gmail.com wrote: > LGTM, but needs a rebase to remove the changes in > Documentation/contributor/issues.itexi. > > > http://codereview.appspot.com/4527086/diff/30001/input/regression/glissando-broken-multiple.ly > File input/regression/glissando-broke

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-30 Thread n . puttock
LGTM, but needs a rebase to remove the changes in Documentation/contributor/issues.itexi. http://codereview.appspot.com/4527086/diff/30001/input/regression/glissando-broken-multiple.ly File input/regression/glissando-broken-multiple.ly (right): http://codereview.appspot.com/4527086/diff

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-28 Thread mtsolo
Thanks Neil! I copied and pasted your function into the code and it works well. I am not used to non-recursive looping functions in Scheme, as I often erroneously conceive of Scheme as a language that doesn't remember the values of variables outside of certain contexts (define, let, etc.). I'll g

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread pkx166h
That looks like the normal problem when compiling with -j2 or -j3 (or -j8). Thanks, I turned it off and had no problems. Oh well. Anyway, no problems with reg tests. http://codereview.appspot.com/4527086/ ___ lilypond-devel mailing list lilypond-

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread percival . music . ca
On 2011/06/27 23:17:21, J_lowe wrote: --no-headers --output out/INSTALL.txt out/INSTALL.texi out/AUTHORS.texi: No such file or directory make[2]: *** [out/AUTHORS.txt] Error 1 make[2]: *** Waiting for unfinished jobs out/INSTALL.texi: No such file or directory make[2]: *** [out/INSTALL.txt] E

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread pkx166h
Sorry, I didn't realise my clipboard buffer was as small as it was. The error was incomplete in the previous comment. I'll try again. --make[2]: Entering directory `/home/james/lilypond-git/Documentation/topdocs' LILYPOND_VERSION=2.15.3 /usr/bin/python ../../scripts/lilypond-book.py -I ./ -I

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread pkx166h
Hello, I get a strange error when I apply this patch and then run 'make'. --make[2]: Entering directory `/home/james/lilypond-git/Documentation/topdocs' LILYPOND_VERSION=2.15.3 /usr/bin/python ../../scripts/lilypond-book.py -I ./ -I ./out -I ../../input -I /home/james/lilypond-git/Documentation -

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread n . puttock
http://codereview.appspot.com/4527086/diff/23001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/4527086/diff/23001/scm/output-lib.scm#newcode798 scm/output-lib.scm:798: (define-public (glissando::before-line-breaking grob) add docstring inside function http://

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread Graham Percival
On Mon, Jun 27, 2011 at 03:17:40PM +0200, m...@apollinemike.com wrote: > > Would you (Mike and Neil) like me to re-start the countdown? Otherwise, > > Neil, if you're happy with Mike's changes, this can be pushed, marked > > closed on Reitveld and fixed on the tracker. > > If you have time to ru

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread Colin Campbell
On 11-06-27 01:16 AM, mts...@gmail.com wrote: http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly File input/regression/glissando-broken-multiple.ly (right): http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread m...@apollinemike.com
On Jun 27, 2011, at 3:14 PM, Colin Campbell wrote: > On 11-06-27 01:16 AM, mts...@gmail.com wrote: >> >> http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly >> >> File input/regression/glissando-broken-multiple.ly (right): >> >> http://codereview.apps

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-27 Thread mtsolo
http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly File input/regression/glissando-broken-multiple.ly (right): http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode7 input/regression/glissando-broken-mul

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-26 Thread n . puttock
http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly File input/regression/glissando-broken-multiple.ly (right): http://codereview.appspot.com/4527086/diff/17001/input/regression/glissando-broken-multiple.ly#newcode7 input/regression/glissando-broken-mul

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-26 Thread m...@apollinemike.com
On Jun 26, 2011, at 4:57 PM, Neil Puttock wrote: > On 13 June 2011 12:03, wrote: > >> My goal is to bypass the default calculation and replace it with this one, >> and it is easier to harvest the information about Y placement relative to >> the staff before line breaking happens. Currently,

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-26 Thread Neil Puttock
On 13 June 2011 12:03, wrote: > My goal is to bypass the default calculation and replace it with this one, > and it is easier to harvest the information about Y placement relative to the > staff before line breaking happens.  Currently, there is no mechanism in > Line_spanner::calc_bound_info

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-24 Thread pkx166h
no problems in reg tests. http://codereview.appspot.com/4527086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-23 Thread m...@apollinemike.com
On Jun 13, 2011, at 1:03 PM, m...@apollinemike.com wrote: > On Jun 12, 2011, at 5:49 PM, n.putt...@gmail.com wrote: > >> On 2011/06/05 10:18:18, mike_apollinemike.com wrote: >>> On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: >> http://codereview.appspot.com/4527086/diff

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-13 Thread mike
On Jun 12, 2011, at 5:49 PM, n.putt...@gmail.com wrote: > On 2011/06/05 10:18:18, mike_apollinemike.com wrote: >> On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: > >>> >>> http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm >>> File scm/output-lib.scm (right): >>> >

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-12 Thread n . puttock
On 2011/06/05 10:18:18, mike_apollinemike.com wrote: On Jun 2, 2011, at 9:00 PM, mailto:n.putt...@gmail.com wrote: > > http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm > File scm/output-lib.scm (right): > > http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm#n

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-05 Thread m...@apollinemike.com
On Jun 2, 2011, at 9:00 PM, n.putt...@gmail.com wrote: > > http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm > File scm/output-lib.scm (right): > > http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm#newcode795 > scm/output-lib.scm:795: (define-public (glissando::

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-02 Thread n . puttock
http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/4527086/diff/7002/scm/output-lib.scm#newcode795 scm/output-lib.scm:795: (define-public (glissando::before-line-breaking grob) Possibly silly question: can't you fold

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-05-31 Thread mtsolo
On 2011/05/31 16:41:01, Neil Puttock wrote: http://codereview.appspot.com/4527086/diff/3001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/4527086/diff/3001/scm/output-lib.scm#newcode798 scm/output-lib.scm:798: (bd `((left . ,l) (right . ,r This overwrit

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-05-31 Thread n . puttock
http://codereview.appspot.com/4527086/diff/3001/scm/output-lib.scm File scm/output-lib.scm (right): http://codereview.appspot.com/4527086/diff/3001/scm/output-lib.scm#newcode798 scm/output-lib.scm:798: (bd `((left . ,l) (right . ,r This overwrites any user overrides for left-broken/right-bro