Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread pkx166h
Thanks everyone Pushed c7edeb3d1c298262efc6c077a3f6d2d62e072a96 http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Graham Percival
On Tue, May 24, 2011 at 10:52:56AM +0100, Trevor Daniels wrote: > percival.music...@gmail.com wrote Tuesday, May 24, 2011 10:14 AM > >On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: > > > >>I think it is worth adding Music classes to the > >>Internal Reference section. This lists all the > >

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Trevor Daniels
percival.music...@gmail.com wrote Tuesday, May 24, 2011 10:14 AM On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: I think it is worth adding Music classes to the Internal Reference section. This lists all the event classes linearly. That would be a separate issue, of course. Sorry,

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread percival . music . ca
On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: I think it is worth adding Music classes to the Internal Reference section. This lists all the event classes linearly. That would be a separate issue, of course. You could add at the end of the See Also section: Installed Files: @file{

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Trevor Daniels
wrote Monday, May 23, 2011 9:37 PM I've made a change to the example. I wasn't sure which file I could @ref to as it wasn't really obvious (to me) to see which default values quoteDuring used - the text says 'etc.' and it may use them all by default. So if you think we could @ref a ly file l

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-23 Thread k-ohara5a5a
On 2011/05/23 20:38:30, J_lowe wrote: 6th Draft. Still looks fine to me. http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-23 Thread pkx166h
6th Draft. James http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-23 Thread pkx166h
On 2011/05/20 07:52:22, t.daniels_treda.co.uk wrote: mailto:pkx1...@gmail.com wrote Thursday, May 19, 2011 5:57 PM > Trevor, do you still object to my last comment about that para? The main use for adjusting quotedEventTypes is to prevent irrelevant clutter being inserted into the quoting s

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-20 Thread Trevor Daniels
pkx1...@gmail.com wrote Thursday, May 19, 2011 5:57 PM Trevor, do you still object to my last comment about that para? The main use for adjusting quotedEventTypes is to prevent irrelevant clutter being inserted into the quoting score, for example dynamics or markup might not be appropriate

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-19 Thread pkx166h
Can I push? Trevor, do you still object to my last comment about that para? I am happy for any suggestions, but hopefully have explained my reasoning. James http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypond-devel@gnu.or

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-13 Thread pkx166h
5th Draft http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1044 Documentation/notation/staff.itely:1044: quotation begins.

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread k-ohara5a5a
http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1092 Documentation/notation/staff.itely:1092: that have the same sounding

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread tdanielsmusic
http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1044 Documentation/notation/staff.itely:1044: quotation begins. It is fol

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread percival . music . ca
On 2011/05/12 15:20:55, J_lowe wrote: Number 4. oops, I didn't mean that you had to upload a new draft -- if Trevor and Keith don't complain, then go ahead and push this. http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypon

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread pkx166h
Number 4. James http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely#newcode1144 Documentation/notation/staff.itely:1144: Quotes can

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread percival . music . ca
LGTM http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely#newcode1144 Documentation/notation/staff.itely:1144: Quotes can also be tag

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-12 Thread pkx166h
Nearly there I hope. Third draft. James http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely#newcode1090 Documentation/notation/sta

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-11 Thread k-ohara5a5a
LGTM http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely#newcode1090 Documentation/notation/staff.itely:1090: The @code{\transpositi

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-11 Thread pkx166h
Reviewers: Graham Percival, Keith, Message: Second Draft http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1022 Documentation/no

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-10 Thread k-ohara5a5a
My suggestion was tiny compared to this patch. http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (left): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#oldcode1086 Documentation/notation/staff