Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-09 Thread Valentin Villenave
On Wed, Jun 9, 2010 at 4:40 PM, James Lowe wrote: > Hey! > >>: ( (I meant, compared to what *I* wrote, of course :) Cheers, V. ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-09 Thread James Lowe
Hey! >: ( ;) Valentin Villenave wrote: On Wed, Jun 9, 2010 at 5:00 AM, wrote: Having gotten approval from Graham and Neil, and having responded to Neil's comments, I'll go ahead and push. I'll also post the set that I'm pushing for completeness. Wow, the CG looks *really* helpful now. Ku

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-09 Thread Valentin Villenave
On Wed, Jun 9, 2010 at 5:00 AM, wrote: > Having gotten approval from Graham and Neil, and having responded to > Neil's comments, I'll go ahead and push.  I'll also post the set that > I'm pushing for completeness. Wow, the CG looks *really* helpful now. Kudos! Cheers, Valentin

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread Carl . D . Sorensen
Having gotten approval from Graham and Neil, and having responded to Neil's comments, I'll go ahead and push. I'll also post the set that I'm pushing for completeness. Thanks, Carl http://codereview.appspot.com/1545043/diff/6001/7001 File Documentation/contributor/programming-work.itexi (rig

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread n . puttock
Hi Carl, LGTM too. Cheers, Neil http://codereview.appspot.com/1545043/diff/6001/7001 File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/1545043/diff/6001/7001#newcode1304 Documentation/contributor/programming-work.itexi:1304: @code{test-redo}? In my e

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread percival . music . ca
Looks good to me! http://codereview.appspot.com/1545043/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Contributor's: Update Regression tests (issue1545043)

2010-06-08 Thread Carl . D . Sorensen
Reviewers: Graham Percival, Message: Thanks for the review. I've posted a new version. Thanks, Carl http://codereview.appspot.com/1545043/diff/1/2 File Documentation/contributor/programming-work.itexi (right): http://codereview.appspot.com/1545043/diff/1/2#newcode1305 Documentation/contrib