Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-25 Thread David Kastrup
Graham Percival writes: > On Sun, Apr 25, 2010 at 5:28 PM, Graham Percival > wrote: >> On Sun, Apr 25, 2010 at 5:19 PM, David Kastrup wrote: >>> >>> So what's up with the patch series? >> >> Sorry, it was still sitting in my "most urgent" mail folder. > > Pushed now as d43f0a2575409659fbdd21b9b

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-25 Thread Graham Percival
On Sun, Apr 25, 2010 at 5:28 PM, Graham Percival wrote: > On Sun, Apr 25, 2010 at 5:19 PM, David Kastrup wrote: >> >> So what's up with the patch series? > > Sorry, it was still sitting in my "most urgent" mail folder. Pushed now as d43f0a2575409659fbdd21b9b17b5f8440cc7268. I even managed to re

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-25 Thread Graham Percival
On Sun, Apr 25, 2010 at 5:19 PM, David Kastrup wrote: > > So what's up with the patch series? Sorry, it was still sitting in my "most urgent" mail folder. I'm testing "make" right now; should start a "make doc" in 5 minutes, and will push as soon as that's finished provided that there's no probl

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-25 Thread David Kastrup
David Kastrup writes: > Graham Percival writes: > >> On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote: >>> >>> On 4/20/10 7:57 AM, "Graham Percival" wrote: >>> >>> > Once it *is* tested, does anybody know how to apply the >>> > patch? I see a "download raw patch set", but we sho

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread David Kastrup
Graham Percival writes: > On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote: >> >> On 4/20/10 7:57 AM, "Graham Percival" wrote: >> >> > Once it *is* tested, does anybody know how to apply the >> > patch? I see a "download raw patch set", but we should obviously keep >> > David's n

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Graham Percival
On Tue, Apr 20, 2010 at 07:06:57PM +0200, Reinhold Kainhofer wrote: > Am Dienstag, 20. April 2010 18:05:13 schrieb Graham Percival: > > On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote: > > > git apply downloaded-patch > > > git commit -a --author="David A. Kastrup " > > > > Ick. I c

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Reinhold Kainhofer
Am Dienstag, 20. April 2010 18:05:13 schrieb Graham Percival: > On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote: > > On 4/20/10 7:57 AM, "Graham Percival" wrote: > > > Once it *is* tested, does anybody know how to apply the > > > patch? I see a "download raw patch set", but we shoul

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Graham Percival
On Tue, Apr 20, 2010 at 08:10:15AM -0600, Carl Sorensen wrote: > > On 4/20/10 7:57 AM, "Graham Percival" wrote: > > > Once it *is* tested, does anybody know how to apply the > > patch? I see a "download raw patch set", but we should obviously keep > > David's name and changelog entries. I feel

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Graham Percival
On Tue, Apr 20, 2010 at 04:24:27PM +0200, David Kastrup wrote: > Carl Sorensen writes: > > > Then commit the changes with an author specification: > > > > git commit -a --author="David A. Kastrup " > > While I appreciate a good joke and Tolkien references, I'd strongly > suggest using my proper

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread David Kastrup
Carl Sorensen writes: > Then commit the changes with an author specification: > > git commit -a --author="David A. Kastrup " While I appreciate a good joke and Tolkien references, I'd strongly suggest using my proper name and Email address for that purpose. -- David Kastrup

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Carl Sorensen
On 4/20/10 7:57 AM, "Graham Percival" wrote: > On Tue, Apr 20, 2010 at 2:19 PM, wrote: >> http://codereview.appspot.com/813048/diff/5001/6001#newcode72 >> Documentation/changes.tely:72: @example >> On 2010/04/20 13:02:15, Carl wrote: >>> >>> I think it would be better to show both the new a

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Carl Sorensen
On 4/20/10 7:57 AM, "Graham Percival" wrote: > On Tue, Apr 20, 2010 at 2:19 PM, wrote: >> http://codereview.appspot.com/813048/diff/5001/6001#newcode72 >> Documentation/changes.tely:72: @example >> On 2010/04/20 13:02:15, Carl wrote: >>> >>> I think it would be better to show both the new a

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread Graham Percival
On Tue, Apr 20, 2010 at 2:19 PM, wrote: > http://codereview.appspot.com/813048/diff/5001/6001#newcode72 > Documentation/changes.tely:72: @example > On 2010/04/20 13:02:15, Carl wrote: >> >> I think it would be better to show both the new and the old syntax in > > I had both versions first.  But I

Re: Change lilypond-book's LaTeX environment option placement (issue813048)

2010-04-20 Thread dak
Reviewers: carl.d.sorensen_gmail.com, Message: Amended. http://codereview.appspot.com/813048/diff/5001/6001 File Documentation/changes.tely (right): http://codereview.appspot.com/813048/diff/5001/6001#newcode72 Documentation/changes.tely:72: @example On 2010/04/20 13:02:15, Carl wrote: I thin