Re: [PATCH]: Fix issue 678

2010-06-05 Thread Carl Sorensen
On 6/5/10 10:32 AM, "James Bailey" wrote: > > > On 27.05.2010, at 19:58, Carl Sorensen wrote: >> >> It will use an \override, so it won't go in the body of the docs, >> but in the >> selected snippets. >> >> The proper procedure is to add an example to input/snippets/new/ >> that shows >> how

Re: [PATCH]: Fix issue 678

2010-06-05 Thread James Bailey
On 27.05.2010, at 19:58, Carl Sorensen wrote: On 5/27/10 11:53 AM, "James Lowe" wrote: Hello Carl Sorensen wrote: Here's a patch, from Hraban as modified by Neil, that allows printing minor chords with lower-case names, instead of with a "m" suffix. Please review: http://codereview.

Re: [PATCH]: Fix issue 678

2010-05-27 Thread Graham Percival
On Thu, May 27, 2010 at 7:56 PM, James Lowe wrote: > Well I need some snippet practice I guess. However I have to wait for it to > be committed to the 'tree' right so I can download the version of LilyPond > that has that new function in it? Yes. If you want to start working on stuff in Document

Re: [PATCH]: Fix issue 678

2010-05-27 Thread James Lowe
Carl, Carl Sorensen wrote: http://codereview.appspot.com/1332042 Assuming this gets approved/pushed or whatever it is that 'happens' to code. Does this mean we need another example in the doc to show this 'new' feature? If so, let me know where in the doc and I can perhaps look at updating i

Re: [PATCH]: Fix issue 678

2010-05-27 Thread Carl Sorensen
On 5/27/10 11:53 AM, "James Lowe" wrote: > Hello > > Carl Sorensen wrote: >> Here's a patch, from Hraban as modified by Neil, that allows printing minor >> chords with lower-case names, instead of with a "m" suffix. >> >> Please review: >> >> http://codereview.appspot.com/1332042 > > Assum

Re: [PATCH]: Fix issue 678

2010-05-27 Thread James Lowe
Hello Carl Sorensen wrote: Here's a patch, from Hraban as modified by Neil, that allows printing minor chords with lower-case names, instead of with a "m" suffix. Please review: http://codereview.appspot.com/1332042 Assuming this gets approved/pushed or whatever it is that 'happens' to code.