Sent: 24 June 2011 16:51
> To: mts...@gmail.com; carl.d.soren...@gmail.com; hanw...@gmail.com
> Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org
> Subject: Re: Fix for issue 1706. (issue4662047)
>
> On 2011/06/24 06:22:48, MikeSol wrote:
>> On 2011/06/23 17:4
...@gmail.com
Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org
Subject: Re: Fix for issue 1706. (issue4662047)
On 2011/06/24 06:22:48, MikeSol wrote:
> On 2011/06/23 17:48:23, hanwenn wrote:
> > * Test missing.
> > * Should print programming_error if dir == CENTER
On 2011/06/24 15:51:14, J_lowe wrote:
Mike I ran a reg test against this new beam code and I get significant
differences on
test-output-distance.ly
Umm...
http://lilypond.org/doc/v2.15/Documentation/contributor/regtest-comparison
... maybe we should change the background of @warning{} boxes
On 2011/06/24 06:22:48, MikeSol wrote:
On 2011/06/23 17:48:23, hanwenn wrote:
> * Test missing.
> * Should print programming_error if dir == CENTER.
> * I'd use linear_combination on dir instead, so it is symmetric in
up/down.
>
Done, done, and done.
Cheers,
MS
Mike I ran a reg test aga
On 2011/06/23 17:48:23, hanwenn wrote:
* Test missing.
* Should print programming_error if dir == CENTER.
* I'd use linear_combination on dir instead, so it is symmetric in
up/down.
Done, done, and done.
Cheers,
MS
http://codereview.appspot.com/4662047/
_
* Test missing.
* Should print programming_error if dir == CENTER.
* I'd use linear_combination on dir instead, so it is symmetric in up/down.
On Thu, Jun 23, 2011 at 11:00 AM, wrote:
> Reviewers: ,
>
> Message:
> I think this'll do it.
>
> Cheers,
> MS
>
> Description:
> Fix for issue 1706.
>
>
LGTM
http://codereview.appspot.com/4662047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
