Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread Carl Sorensen
On 7/30/11 5:26 PM, "James Lowe" wrote: > > OK I see (although I think we got off topic there) so why not make stop\start, > as an explicit command, rounded; and whatever you call 'end of barlines' that > are either \break-ed or whatever LP does when it starts a 'new line' squared? No need t

RE: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread James Lowe
; Han-Wen Nienhuys Cc: re...@codereview.appspotmail.com; lilypond-devel@gnu.org Subject: Re: Ends of barlines are hidden in staff lines. (issue4809057) On 7/30/11 3:35 PM, "pkx1...@gmail.com" wrote: > On 2011/07/30 16:15:39, c_sorensen_byu.edu wrote: > > >> I think that

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread Carl Sorensen
On 7/30/11 3:35 PM, "pkx1...@gmail.com" wrote: > On 2011/07/30 16:15:39, c_sorensen_byu.edu wrote: > > >> I think that the stop/start staves is currently exactly what it should > do. >> It stops the staff at a location, and starts the staff at the same > location. >> It reflects the commands

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread Janek Warchoł
2011/7/30 Carl Sorensen : > On 7/30/11 10:07 AM, "Janek Warchoł" wrote: >> Actually, there is a problem with stop/start staves already - see >> attached. Maybe staff lines shouldn't be rounded? I know that we >> round most things, but i think it's not that much important in case of >> stafflines,

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread pkx166h
passes make and reg tests look fine. http://codereview.appspot.com/4809057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread pkx166h
On 2011/07/30 16:15:39, c_sorensen_byu.edu wrote: I think that the stop/start staves is currently exactly what it should do. It stops the staff at a location, and starts the staff at the same location. It reflects the commands that have been issued. If the staff is continuous, there is n

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-30 Thread Carl Sorensen
On 7/30/11 10:07 AM, "Janek Warchoł" wrote: > 2011/7/29 Han-Wen Nienhuys : > >> then again, if the barline is horizontally aligned, it may not be a >> problem. I think the problem may still occur if you stop/start staves >> half-way the page, but we may decide it's not important enough. > > Act

Re: Ends of barlines are hidden in staff lines. (issue4809057)

2011-07-29 Thread Han-Wen Nienhuys
On Fri, Jul 29, 2011 at 2:15 AM, wrote: > Reviewers: hanwenn, > > Message: > > http://lists.gnu.org/archive/html/lilypond-devel/2011-07/msg01051.html > 2011/7/27 Han-Wen Nienhuys : > Due to rounding, PDF viewers can err the placement of the barline by a pixel. [so that it looks lik