I think I've hit loose column nirvana with this most recent patch set.
The only thing that I know I need to work on is the magic left_padding
number of 0.15 in spacing-loose-columns.cc . I know this should be made
a property but I don't know where (I can implement it like it was
implemented in pr
Hi Mike,
The latest patch set breaks spacing-empty-bar.ly (we want
left-loose-column-padding to be 0 in this case), but apart from that it
looks great.
Cheers,
Neil
http://codereview.appspot.com/4841052/diff/14002/input/regression/loose-column-spacing.ly
File input/regression/loose-column-spac
LGTM (still one trailing whitespace in the regtest).
Bertrand
http://codereview.appspot.com/4841052/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Aug 9, 2011, at 4:30 PM, bordage.bertr...@gmail.com wrote:
> What if we want a larger padding?
> In your regtest, the clef collides with the third notehead when we set
> the padding with:
> \override Score.SpacingSpanner #'left-loose-column-padding = #2
>
Hm...good question! I've uploaded a
What if we want a larger padding?
In your regtest, the clef collides with the third notehead when we set
the padding with:
\override Score.SpacingSpanner #'left-loose-column-padding = #2
There's also two trailing whitespaces.
Regards,
Bertrand
http://codereview.appspot.com/4841052/diff/6001/in
Hey all,
I'm pretty sure this is the best way to get around the loose column
issue for now.
The problem (I think) is that some invisible BarLine grobs act as
alignment markers and thus can be slid well left of the two grobs they
were originally supposed to fall between. A distinction needs to b
On Sat, 06 Aug 2011 01:52:27 -0700, m...@apollinemike.com
wrote:
Do you know where these reference points are specified?
No, but the extents of each glyph are calculated relative to the reference
points,
so from the extents we can figure how long to make the rods to prevent the
glyphs fro
On Aug 5, 2011, at 9:49 PM, Keith OHara wrote:
> gmail.com> writes:
>
>>
>> I was assuming that a rod
>> attaches to the right of the left `between-columns' and the left of the
>> right one? Is this not the case?
>>
>
> I haven't tried the patch yet, but the rods of rods-and-springs measure
gmail.com> writes:
>
> I was assuming that a rod
> attaches to the right of the left `between-columns' and the left of the
> right one? Is this not the case?
>
I haven't tried the patch yet, but the rods of rods-and-springs measure from
the
reference points of the objects.
The left- and
Reviewers: ,
Message:
Hey all,
This patch makes some headway into the loose column problem, but I am
running into a problem with the length of the rod placed for the loose
column. Could C++ people with a bit of time please apply this patch,
look at the result, and then look at the pretty print
10 matches
Mail list logo
