Re: Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-25 Thread jonas . hahnfeld
On 2019/11/25 02:44:20, Dan Eble wrote: On 2019/11/24 11:47:01, hahnjo wrote: > On 2019/11/23 16:45:17, Dan Eble wrote: > > If an XML file is opened as a binary file, will the treatment of > > platform-specific line endings become inconvenient for some people? > > I hope it does not: Once we kn

Re: Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-24 Thread nine . fierce . ballads
On 2019/11/24 11:47:01, hahnjo wrote: On 2019/11/23 16:45:17, Dan Eble wrote: > If an XML file is opened as a binary file, will the treatment of > platform-specific line endings become inconvenient for some people? I hope it does not: Once we know it's really text, the code will call decode('u

Re: Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-24 Thread jonas . hahnfeld
Reviewers: lemzwerg, Dan Eble, Message: On 2019/11/23 16:45:17, Dan Eble wrote: > 3. Open midi and musicxml files in binary mode > Only decode once we are sure that the content is not compressed. If an XML file is opened as a binary file, will the treatment of platform-specific line endings b

Re: Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-23 Thread nine . fierce . ballads
3. Open midi and musicxml files in binary mode Only decode once we are sure that the content is not compressed. If an XML file is opened as a binary file, will the treatment of platform-specific line endings become inconvenient for some people? https://codereview.appspot.com/573280043/

Prepare for encoding changes in Python 3 (issue 573280043 by jonas.hahnf...@gmail.com)

2019-11-23 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks! https://codereview.appspot.com/573280043/