Re: Potential issue 39 fix w/ patch

2011-01-08 Thread Mike Solomon
New patch set that moves the stem up - regtests check out OK.http://codereview.appspot.com/3934041/For some reason, the side-by-side diffs don't work for the last file, but as you'll see in the unified diff, the change is trivial.Attached is a PDF of the regtest I created for this patch.Cheers,MS

Re: Potential issue 39 fix w/ patch

2011-01-07 Thread Keith OHara
Original Message > From: "Mike Solomon" > Sent: Thursday, January 06, 2011 10:03 AM > Mike, The patch moves 8th notes unnecessarily. The patch breaks the collision resolution of dotted notes. If you have to move the notehead, you're moving it the wrong direction. Test musi

Re: Potential issue 39 fix w/ patch

2011-01-06 Thread Mike Solomon
Thanks Keith, I'm sure that you can change stem length at that point in the code. I'll put together something and send it out. I don't mind the horizontal shift, as simultaneous notes are always horizontally shifted if they are the same notable near neighbors. The problem arises when it causes

Potential issue 39 fix

2011-01-06 Thread mike
I've included before and after photos. Cheers, MS 0001-Potential-fix-for-issue-39.patch Description: Binary data <><>___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Potential issue 39 fix w/ patch

2011-01-05 Thread Keith OHara
Mike Solomon ufl.edu> writes: > I've included before and after photos. Hi Mike. The hemidemisemiquaver(*) and the minim are supposed to be simultaneous, so I do not like the horizontal shift. There is no mention in issue 39 of the desired output. The only thing I can imagine wanting done auto

Potential issue 39 fix w/ patch

2011-01-05 Thread Mike Solomon
I've included before and after photos.Cheers,MS 0001-Potential-fix-for-issue-39.patch Description: Binary data <><>___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel